Oh nice, I didn't have them down since no reviews have been uploaded to Rietveld in... ages.

I'm happy to do this migration for you on Wednesday, Sept 27th, at the same time as I do catapult and syzygy.

What mailing list(s) should I send PSAs to?

sent you the internal address over internal IM.

Thanks!

I need two other things from you:
1) The name on chromium.googlesource.com that you would like this repo to have. We won't use the current spot (external/github.com/GoogleChrome/custom-tabs-client) since that is explicitly a mirror. What path do you want?
2) For chromium-infra-bot (https://github.com/chromium-infra-bot) to be granted Write access to all branches of the GitHub repository

Once I have those, I can create the new source-of-truth repo and will be able to set up mirroring back to GitHub.

I've added the infra bot to the repo where its currently hosted. FYI, the repo is slated to move to GoogleChromeLabs.

back from leave .. sorry for delay

1) I am guessing that it is probably easier for you to create a new repo, but I would prefer to repurpose th old one to become the source of truth. I cannot remember why we cannot do that. Having the repo hosted in 3 places (the source of truth on googlesource, the github mirror and the mirror in googlesource?) is confusing. AFAIR there might be inconvenience in deleting a repo (because of the dangling links), but repurposing does not have this issue.

If there is no way to repurpose, I'd suggest something like https://chromium.googlesource.com/custom-tabs-client with a comment on chromium.googlesource.com for each repo to say what status it is in right now. Is there a way to do that? I see comments for some repos, but not others.

2) I think we should ask https://github.com/PaulKinlan to grant Write access, I don't seem to have the rights, but I may still have the Write access itself.

Hi!

Sorry for the delay on my end as well. I actually had a related question.

I just uploaded my first change after this migration here: https://chromium-review.googlesource.com/c/external/github.com/GoogleChrome/custom-tabs-client/+/702858 and it seems to be read-only, I think...

Was there something else I need to do for uploading new changes?

Please let me know if there is a better venue/bug to raise this issue.

 Issue 776031  has been merged into this issue.

Sorry, this got lost in the shuffle. Now that I have the answers in Comment 6, I'll wrap this up this week and make sure that everyone has all the right permissions.

Any updates on this? Sorry, we kind of have a few CLs queued up for this repo.

https://chromium.googlesource.com/custom-tabs-client now exists.

It has basically the same permissions as chromium/src.git; i.e. currently only Chromium committers can CR+1 changes in the repo. If we need to change that list, let me know who should be a committer.

This new repo is being mirrored to external/github.com/GoogleChrome/custom-tabs-client, just like the GitHub repo was. I have also updated that mirror repo with a description saying where the real repo is, and to prevent anyone from uploading code reviews there.

In the near future (as soon as PaulKinlan grants chromium-infra-bot Write access to the github repo), it will be mirrored back to GitHub as well.

Anyone with in-flight changes on Gerrit should re-upload them after https://chromium-review.googlesource.com/#/c/custom-tabs-client/+/755479 lands.

The CQ permissions are all in place; the CQ will start running after https://chrome-internal-review.googlesource.com/c/infra/puppet/+/497173 lands.

I'm updating the documentation here: https://canary-chromium-review.googlesource.com/#/c/custom-tabs-client/+/755515

I'll send that change through the CQ to make sure that is working correctly as well.

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/984072250833c2acf509ed291b2f02b874e033ea

commit 984072250833c2acf509ed291b2f02b874e033ea
Author: Aaron Gable <agable@chromium.org>
Date: Mon Nov 06 20:44:30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/custom-tabs-client/+/9f574600506f71c06054b56e730e40e609e5a864

commit 9f574600506f71c06054b56e730e40e609e5a864
Author: Aaron Gable <agable@chromium.org>
Date: Mon Nov 06 20:46:02 2017

Update custom-tabs-client to use Gerrit for codereview

Bug:  766215 
Change-Id: Ia9ca9ac9f95ceb3b0c0879fef1c42809c27ed698
Reviewed-on: https://chromium-review.googlesource.com/755479
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>

[modify] https://crrev.com/9f574600506f71c06054b56e730e40e609e5a864/infra/config/cq.cfg
[modify] https://crrev.com/9f574600506f71c06054b56e730e40e609e5a864/codereview.settings

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/51c7e4821a949fbac344592a32828533283558b6

commit 51c7e4821a949fbac344592a32828533283558b6
Author: Aaron Gable <agable@chromium.org>
Date: Mon Nov 06 21:48:43 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/custom-tabs-client/+/f7d39584f662d997ab4beb623085971ae2b6b8d5

commit f7d39584f662d997ab4beb623085971ae2b6b8d5
Author: Aaron Gable <agable@chromium.org>
Date: Mon Nov 06 23:47:24 2017

Update README and CONTRIBUTING for Gerrit review

R=yusufo

Bug:  766215 
Change-Id: I4953ad35bfe8ccfc8be5e471c0b2473db45a33b6
Reviewed-on: https://chromium-review.googlesource.com/755515
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/f7d39584f662d997ab4beb623085971ae2b6b8d5/CONTRIBUTING.md
[modify] https://crrev.com/f7d39584f662d997ab4beb623085971ae2b6b8d5/README.md

Change landed via CQ!

This is now done, except for the mirroring back to the old GitHub repo, which I need Paul Kinlan to grant permission for.

nice! can you reach to Paul via IM?

I am still having trouble uploading patches, now at the upload stage itself. Do I need new credentials for this repo now?

fatal: remote error: push at least one ref not permitted

Error after CL description prompt -- saving description to /usr/local/google/home/yusufo/.git_cl_description_backup

Failed to create a change. Please examine output above for the reason of the failure.
Hint: run command below to diagnose common Git/Gerrit credential problems:
  git cl creds-check

Yes, follow the directions: run "git cl creds-check" and it will tell you what you need to do to have appropriate credentials set up.

I run ""git cl creds-check" and it gives some warning like

.gitcookies problem report:
.googlesource.com wildcard record Chrome Infrastructure team recommends to list full host names explicitly.

but nothing helpful to solve the problem.

Hmm sorry, I thought it had more helpful messages than that. Consider filing a bug against tandrii@ to improve it.

In the mean time, some tips for .gitcookies:
1) Don't have any *.googlesource.com entries, they confuse things
2) Go to chromium.googlesource.com/new-password and sign in with your @chromium to generate a new entry for that host
3) Do the same for chrome-internal.googlesource.com/new-password and sign in with your @google

Sorry for the step 3), just want to make sure should I login with @google or @chromium?

Also then after step 2, looks like in my .gitcookies I have both google.com and chromium.org, so should I keep all of them or delete all google.com?

For step (3), use @google.com. Your @chromium.org account does not have permission to access chrome-internal, so you should use your @google.com. It is totally fine (in fact, necessary) to have both @google and @chromium in your .gitcookies file, as long as they are associated with different hosts.

Yes, that's because you signed in with your @google.com account on chromium.googlesource.com/new-password, but that's the external host where @chromium accounts should be used.

So I did follow the instructions and now have upstream creds with chromium account and internal with google account, but still can't upload.

Another thing is for CL that was uploaded that we can view in gerrit like this one https://chromium-review.googlesource.com/c/external/github.com/GoogleChrome/custom-tabs-client/+/702858, I don't see any controls to review the change at all, although I am signed in with my @chromium account where I am a committer. This shouldn't be related with my local setup. I feel like there is something still missing in the configuration for this repo.

Ah, I see what's happening. I forgot to list a necessary step in Comment 12, and I apologize for that.

In your custom-tabs-client repository, please run
`git config remote.origin.url https://chromium.googlesource.com/custom-tabs-client`

This should only be necessary for people who want to upload changes immediately; other people should be able to wait until after https://chromium-review.googlesource.com/#/c/chromium/src/+/758743 lands, assuming they contribute from inside their chromium checkout.

Again, terribly sorry that I forgot to list that step. I'm way off my game.

That works! I can now upload the CL after that command. Thank you for the guidance! 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c91d977cfcee9156b490651479f54943dd612ea

commit 7c91d977cfcee9156b490651479f54943dd612ea
Author: Aaron Gable <agable@chromium.org>
Date: Tue Nov 21 01:27:06 2017

Update source for custom-tabs-client dependency

This repo is now homed on chromium.googlesource.com, rather than
mirrored from GitHub.

R=yusufo

Bug:  766215 
Change-Id: Iac368e407118e647cddf8e6f67b0c9b6357ab141
Reviewed-on: https://chromium-review.googlesource.com/758743
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518024}
[modify] https://crrev.com/7c91d977cfcee9156b490651479f54943dd612ea/DEPS

Just to capture the next step here: the github.com/chromium-infra-bot needs to be granted write access to all the branches in the github repo in order to mirror the changes from the chromium-side copy.

The repository is now being mirrored to GitHub on a continuous basis.

> The repository is now being mirrored to GitHub on a continuous basis.

Thank you thank you thank you! :)