New issue
Advanced search Search tips

Issue 766206 link

Starred by 1 user
Status: Fixed
Owner:
justincohen@chromium.org
Closed: Sep 20
Cc:
justincohen@chromium.org
pkl@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove #if defined(__IPHONE_11_0) && (__IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_11_0)

Project Member Reported by jif@chromium.org, Sep 18 2017 
Now that Chrome for iOS is building with the iOS11 SDK, we can remove those #ifs.

And while we are at it, we can also remove __IPHONE_7_0, __IPHONE_8_0, __IPHONE_9_0, and __IPHONE_10_0 from the codebase!
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 19

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by justincohen@chromium.org, Sep 20

Owner: justincohen@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2121e18d2b42de6a7bed5556b152951dc5d7d8f2

commit 2121e18d2b42de6a7bed5556b152951dc5d7d8f2
Author: Justin Cohen <justincohen@google.com>
Date: Thu Sep 20 15:15:20 2018

[ios] Remove compile time guards for Xcode 9 and 10.

Bug:  766206 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ifb5996a5491bde08885517ad56a539d73cf60260
Reviewed-on: https://chromium-review.googlesource.com/1235223
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592805}
[modify] https://crrev.com/2121e18d2b42de6a7bed5556b152951dc5d7d8f2/ios/chrome/app/main_application_delegate.mm
[modify] https://crrev.com/2121e18d2b42de6a7bed5556b152951dc5d7d8f2/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/2121e18d2b42de6a7bed5556b152951dc5d7d8f2/ios/chrome/browser/drag_and_drop/drop_and_navigate_interaction.h
[modify] https://crrev.com/2121e18d2b42de6a7bed5556b152951dc5d7d8f2/ios/chrome/browser/drag_and_drop/drop_and_navigate_interaction.mm
[modify] https://crrev.com/2121e18d2b42de6a7bed5556b152951dc5d7d8f2/ios/chrome/browser/drag_and_drop/drop_and_navigate_interaction_unittest.mm
[modify] https://crrev.com/2121e18d2b42de6a7bed5556b152951dc5d7d8f2/ios/chrome/browser/metrics/drag_and_drop_recorder.mm
[modify] https://crrev.com/2121e18d2b42de6a7bed5556b152951dc5d7d8f2/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
[modify] https://crrev.com/2121e18d2b42de6a7bed5556b152951dc5d7d8f2/ios/chrome/browser/ui/qr_scanner/camera_controller.mm
[modify] https://crrev.com/2121e18d2b42de6a7bed5556b152951dc5d7d8f2/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
[modify] https://crrev.com/2121e18d2b42de6a7bed5556b152951dc5d7d8f2/ios/chrome/browser/ui/tabs/tab_view.mm
[modify] https://crrev.com/2121e18d2b42de6a7bed5556b152951dc5d7d8f2/ios/web/net/cookies/wk_http_system_cookie_store.h
[modify] https://crrev.com/2121e18d2b42de6a7bed5556b152951dc5d7d8f2/ios/web/net/cookies/wk_http_system_cookie_store.mm
[modify] https://crrev.com/2121e18d2b42de6a7bed5556b152951dc5d7d8f2/ios/web/net/cookies/wk_http_system_cookie_store_unittest.mm

Comment 4 by justincohen@chromium.org, Sep 20

Status: Fixed (was: Started)
►

Sign in to add a comment