Issue metadata
Sign in to add a comment
|
git cl upload "fails" but doesn't fail |
||||||||||||||||||||||||
Issue descriptionGot this message when uploading: marja@marja:~/code/v8$ git cl upload Running presubmit upload checks ... Done processing /usr/local/google/home/marja/code/v8/test/cctest/parsing/test-scanner-streams.cc Total errors found: 0 Total violating files: 0 Presubmit checks passed. src/parsing/scanner-character-streams.cc | 7 ++++++- test/cctest/parsing/test-scanner-streams.cc | 47 ++++++++++++++++++++++++++++++------------- 2 files changed, 39 insertions(+), 15 deletions(-) remote: Processing changes: new: 1, done remote: (W) 802af1a: commit subject >50 characters; use shorter first paragraph remote: (W) 802af1a: too many commit message lines longer than 72 characters; manually wrap lines remote: remote: New Changes: remote: https://chromium-review.googlesource.com/#/c/v8/v8/+/670729 [scanner] UTF-8 handling fix (errors near chunk end). remote: To https://chromium.googlesource.com/v8/v8.git * [new branch] 802af1a7a619d1b2fc9f0170691640388d132718 -> refs/for/refs/heads/master%wip,m=Initial_upload Error after CL description prompt -- saving description to /usr/local/google/home/marja/.git_cl_description_backup Created|Updated 0 issues on Gerrit, but only 1 expected. Change-Id: I8ca946dfdb39244c5ca0bdcebe047047010b3a07 ------------------- When I try e.g., "git cl try", I get an error message: Usage: git cl try [options] git cl: error: Need to upload first ------------------- However, the CL was created just fine: https://chromium-review.googlesource.com/#/c/v8/v8/+/670729 When I tried to redo "git cl upload", the same "error" happened again and it created another CL.
,
Sep 18 2017
,
Sep 18 2017
,
Sep 29 2017
This *was* a minor annoyance, since I could always do "git cl issue" to associate the branch with the correct issue, and everything would work. But then I realized that when one CL is in this "failed but not failed" state, uploading all dependent CLs (branch created with git new-branch --upstream-current) fails for real. The error message is: Upload upstream branch foo. It is likely that this branch has been rebased since its last upload, so you just need to upload it again. (If you uploaded it with --no-squash, then branch dependencies are not supported, and you should reupload with --squash.) --------- Also, the super low 50 char limit conflict with our commit message format: [component]: Feature: Change description. Can you provide some pointers to where these character limits were agreed on? (Also, currently there's no way to get notified about this char limits before doing git cl upload, which sets the CL into this "failed but not failed" state, so the overall UX is not optimal.)
,
Oct 17 2017
,
Oct 21 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by marja@chromium.org
, Sep 18 2017