New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766191 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Voice search is not functional when launch from today view

Project Member Reported by rakurati@chromium.org, Sep 18 2017

Issue description

App Version: 62.0.3202.27 beta
iOS Version: 10.3.3 only
Device: iPhone and iPad

Steps to reproduce:
1. Force quit the chrome
2. Swipe down Today's View.
3. Tap on Voice Search button under chrome in Today's View 

Observed results:
GLIF animation is displays and closes immediately

Note: After fresh install the voice search will work as expected with above steps only for the first time (i.e.after providing permissions to access microphone) 

Expected results:
GLIF animation should be displayed.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): Yes on M61
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M62

Link to video/image:
https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8R3ptYXV4Ym1walE/view?usp=sharing

 

Comment 1 by edchin@chromium.org, Sep 18 2017

Cc: lod@chromium.org
Labels: M-63
Owner: olivierrobin@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by edchin@chromium.org, Sep 18 2017

Cc: kkhorimoto@chromium.org
Labels: ReleaseBlock-Stable M-62
Status: Started (was: Assigned)
Cc: pinkerton@chromium.org noyau@chromium.org cma...@chromium.org mard...@chromium.org
This is caused by |applicationWillResignActive| being called immediately when launching app from URL.
This seems new in iOS 10.3.2 and 10.3.3
Not sure if this is a bug, but I can reproduce in a sample app.

+oh as this is RBS.
This seems to be affect random devices as I can reproduce on test devices (iPhone 6Plus), but neither mardini or noyau (who both have 6S running 10.3.3).

What iPhone did you use? Are they iPhone 6 plus?

I am using iPhone7, iPhone 6S plus and iPhone5, able to reproduce on all these devices.
I filed rdar://34543072 even if there is really little chance that it is address as the behavior in iOS11 is different.
I want to ask if this is RBS.
Rational for not RBS
- it is already release as it reproduce in M61
- it has not been reported by our users, and it seems somehow to only reproduce on test devices...
- iOS11 will be released before M62 and fix the bug anyway.

Rationale for RBS
- We are launching new extension, it would be great if VS works in it.

mardini, cmasso, wdyt?
Note that this only reproduce if you swipe *down* the notification center.
Not if you swipe it right.
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41e05778e7394f4c3a2ae48387997ec7cee6181d

commit 41e05778e7394f4c3a2ae48387997ec7cee6181d
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Wed Sep 20 09:31:31 2017

Delay Voice search startup by 100ms on iOS 10.

When launching app from today extension on iOS10, application delegate
receives
applicationDidBecomeActive
applicationWillResignActive
applicationDidBecomeActive

The resign cause Voice search to be dismissed.
Wait for 100ms before starting voice search to avoid this issue.

Bug:  766191 
Change-Id: I0b76ea681ea541bd2e8bd83f4dd7e8ec90743c29
Reviewed-on: https://chromium-review.googlesource.com/673186
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503094}
[modify] https://crrev.com/41e05778e7394f4c3a2ae48387997ec7cee6181d/ios/chrome/app/main_controller.mm

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-62; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-62 label, otherwise remove Merge-TBD label. Thanks.
Merge to be determined at office hours.
Labels: -Merge-TBD -M-62
As decided in OH, this will not be cherry-picked in 62.
Status: Verified (was: Fixed)
Verified on M63.0.3237.0 canary
iOS: 10.3.3 Device: iPad Air 2

Sign in to add a comment