New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766184 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 754872

Blocking:
issue 672961



Sign in to add a comment

Cursor becomes invisible for ARC++ apps on mushrome

Project Member Reported by penghuang@chromium.org, Sep 18 2017

Issue description

Repro steps.
1. Launch arc++ apps (play store, etc) on mushrome
2. Move the cursor into the arc++ apps window.
3. The cursor will become invisible


 
Cc: osh...@chromium.org
Blocking: 672961 728695
Cc: sky@chromium.org kylec...@chromium.org samans@chromium.org fsam...@chromium.org
Owner: fsam...@chromium.org
Status: Assigned (was: Available)
I confirmed the problem is because the viz::CopyOutputRequest doesn't work with mus.

FYI, In wayland the cursor is a surface. In exo, every surface is an aura::Window. To use hardware cursor, exo submits a frame with the cursor surface and uses CopyOutputRequest to get composited result of the frame as a SkBitmap, and then convert it to a ui::PlatformCursor.

fsamuel@, could you please take a look? Thanks.

Comment 3 by sky@chromium.org, Sep 25 2017

Cc: m...@chromium.org
I think this will be fixed by the work miu@ is doing. Doing I have that right

Comment 4 by m...@chromium.org, Sep 26 2017

Not sure: I've never looked at ARC++ before, so I don't know about the graphics paths or UI resource issues involved here.
To fix this issue we need support CopyOutputRequest in mus and mash. See Pointer::CaptureCursor() [1] for the detail.

[1] https://cs.chromium.org/chromium/src/components/exo/pointer.cc?sq=package:chromium&dr&q=CopyOutputRequest+file:%5Esrc/components/exo/+package:%5Echromium$&l=350
Labels: -event-targeting
Owner: m...@chromium.org
miu@ Do we have a plan to support CopyOutputRequest in mus world? 

Comment 7 by m...@chromium.org, Oct 16 2017

We want this, but there is no design yet, AFAIK. Actually, it should be trivial...just some minor plumbing.

My priority is to get tab/desktop capture working first. From those efforts, it's likely one-off snapshots will be easy to get running.

Comment 8 by m...@chromium.org, Oct 16 2017

Blockedon: 754872
Fyi, I landed some cursor fixes in exo that that most likely leaves the cursor as the default cursor for exo windows on Mus.

Comment 10 by sky@chromium.org, Nov 10 2017

Owner: penghuang@chromium.org
Peng, could you reevaluate this and see if it's still an issue?
With reveman's change, we will have a cursor for ARC++ on mus, but it is not the cursor set by ARC++. 

Comment 12 by sky@chromium.org, Nov 10 2017

Owner: m...@chromium.org
That's an improvement:)
Blocking: -728695
We have a workaround for this issue, so it doesn't block mushrome anymore.
Components: -Internals>MUS Internals>Services>WindowService
Labels: -Proj-Mustash-Mus-WS
Deprecating label Proj-Mustash-Mus-WS in favor of Components.

Comment 16 by m...@chromium.org, May 19 2018

Owner: penghuang@chromium.org
CopyOutputRequests do work with mus now (for about a month or two now). Is this bug still a problem? Re-assigning back to original requestor to see if the problem is resolved and we should WontFix...

Comment 17 by sky@chromium.org, May 21 2018

Status: WontFix (was: Assigned)
--mus has been nuked, so I don't think this is an issue anymore.

Sign in to add a comment