[WebPayments] Change printed error for duplicate shipping options to TypeError |
|||
Issue descriptionIf there're duplicate shipping options in PaymentRequestUpdateEvent.updateWith(), then PaymentRequest.show() should reject with "TypeError". Currently prints a warning instead.
,
Sep 27 2017
Looking into this, the code *appears* to be throwing a TypeError as desired, but the test is receiving a SyntaxError and therefore failing. The next step is to get in with the JS debugger and figure out why our TypeError is being transfigured into a SyntaxError by the time the test harness inspects it.
,
Oct 23 2017
Found the issue. Preparing a fix
,
Oct 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c973b1752686bb8a103505fe51846c96eb605395 commit c973b1752686bb8a103505fe51846c96eb605395 Author: Mathieu Perreault <mathp@chromium.org> Date: Mon Oct 23 18:02:56 2017 [Payments] Use GetException from ExceptionState when rejecting Promise Was using SyntaxError which was a mistake because the exception could have been something else. Bug: 766171 Change-Id: I578e495047e422d616e0d77c253d0a322cd1ef7b Reviewed-on: https://chromium-review.googlesource.com/733145 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#510845} [modify] https://crrev.com/c973b1752686bb8a103505fe51846c96eb605395/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
,
Oct 23 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tmartino@chromium.org
, Sep 18 2017