New issue
Advanced search Search tips

Issue 766170 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Payment-Interop


Sign in to add a comment

[Payments] WPT: Throw TypeError if amount if not valid.

Project Member Reported by ma...@chromium.org, Sep 18 2017

Issue description

For each option in details.shippingOptions: if option.amount.value is not a valid decimal monetary value, then throw a TypeError
 

Comment 2 by ma...@chromium.org, Sep 18 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd2bd69261deb7d12900c1a18c605d9ab3a380cb

commit cd2bd69261deb7d12900c1a18c605d9ab3a380cb
Author: Mathieu Perreault <mathp@chromium.org>
Date: Mon Sep 18 20:00:47 2017

[Payments] Blink: only perform shipping option validation if requestShipping

Previously would always validate amounts regardless of requestShipping value.
Now only validates when shipping is requested by the API user.

Bug:  766170 
Test: blink_tests
Change-Id: I2d1138951e1fa284f36b9fd974857e4f17e7c970
Reviewed-on: https://chromium-review.googlesource.com/671109
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502655}
[modify] https://crrev.com/cd2bd69261deb7d12900c1a18c605d9ab3a380cb/third_party/WebKit/LayoutTests/external/wpt/payment-request/payment-request-constructor.https-expected.txt
[modify] https://crrev.com/cd2bd69261deb7d12900c1a18c605d9ab3a380cb/third_party/WebKit/LayoutTests/external/wpt/payment-request/payment-request-ctor-currency-code-checks.https.html
[modify] https://crrev.com/cd2bd69261deb7d12900c1a18c605d9ab3a380cb/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Comment 4 by ma...@chromium.org, Sep 18 2017

Status: Fixed (was: Started)

Sign in to add a comment