New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 766160 link

Starred by 1 user
Status: Assigned
Owner:
rouslan@chromium.org
Cc:
█ mcace...@mozilla.com
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
Payments-TechDebt


Sign in to add a comment

Neither chrome://settings/autofill no PaymentRequest set the languageCode for newly created i18n addresses

Project Member Reported by rouslan@chromium.org, Sep 18 2017 
Chrome Version       : 63.0.3213.3
OS: Linux
URLs (if applicable) : chrome://settings/autofill https://rsolomakhin.github.io/pr/free/

What steps will reproduce the problem?
1. Add a Japanese address either in chrome://settings/autofill or via PaymentRequest UI on desktop.
2. Attempt to ship to this address from https://rsolomakhin.github.io/pr/free/ via PaymentRequest.

What is the expected result?
The shipping address should have either ja-Latn or ja-JP languageCode field.

What happens instead of that?
The shipping address has empty languageCode field.

Please provide any additional information below. Attach a screenshot if
possible.
Android works as expected.

UserAgentString: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3213.3 Safari/537.36
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df2feb4e9c3e0333041d15e338254689f68d6198

commit df2feb4e9c3e0333041d15e338254689f68d6198
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Mon Sep 18 17:15:22 2017

[Payments] Set language code for edited address.

Bug: 766160
Change-Id: I6635b17a8f28ccf0ba4086be4cc6b1f82dceb874
Reviewed-on: https://chromium-review.googlesource.com/671143
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502599}
[modify] https://crrev.com/df2feb4e9c3e0333041d15e338254689f68d6198/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/df2feb4e9c3e0333041d15e338254689f68d6198/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h

Comment 2 by rouslan@chromium.org, Sep 18 2017

Cc: dpa...@chromium.org
Components: UI>Settings
Demetrios: can you explain how profile creation works in chrome://settings/autofill so I can fix this issue there?

Comment 3 by dpa...@chromium.org, Sep 18 2017

Labels: Proj-MaterialDesign-WebUI
Hi Rouslan. Clicking "save" on the chrome://settings/autofill "add address" dialog ends up calling chrome.autofillPrivate.saveAddress() API at [1], which is implemented at [2]. Passed that point, I am not familiar with how this information is routed to other parts of Chrome.

[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js?l=101
[2] https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/autofill_private/autofill_private_api.cc?l=176

Comment 4 by rouslan@chromium.org, Sep 19 2017 

Demetrios: Does JavaScript keep around the languageCode parameter that comes back with the list of the address input fields anywhere?

Comment 5 by dpa...@chromium.org, Sep 19 2017 

Within the "add address dialog" the country code of the currently displayed input fields is kept at [1]. There is also a list of all countries, which includes the country code for each entry, at [2].

[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js?l=186
[2] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js?l=55

Comment 6 by ma...@chromium.org, May 1 2018

Components: UI>Browser>Autofill
►

Sign in to add a comment