New issue
Advanced search Search tips

Issue 766156 link

Starred by 1 user
Status: Fixed
Owner:
na...@chromium.org
Closed: Jul 11
Cc:
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Feature



Sign in to add a comment

Background Fetch should update notification title when updateUI is called

Project Member Reported by joh...@chromium.org, Sep 18 2017 
Currently when updateUI is called on a Background Fetch, the new title is persisted to the database (as of https://chromium-review.googlesource.com/c/chromium/src/+/668541), but we don't yet update the title of the notification (because notifications aren't yet implemented :p). This issue tracks making the titles update.

Comment 1 by na...@chromium.org, Jul 4

Owner: na...@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e44786837d145a536811e26411f0484d0b2faaf

commit 5e44786837d145a536811e26411f0484d0b2faaf
Author: Mugdha Lakhani <nator@chromium.org>
Date: Fri Jul 06 16:43:46 2018

[Background Fetch] UpdateUI() should update title of the UI.

We currently update the title in persisted storage. After this change,
the updated title will also be reflected in the notification UI.

Bug:  766156 
Change-Id: Ia8c79de2ff438676081d9467476de86d5c3be95a
Reviewed-on: https://chromium-review.googlesource.com/1126248
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572993}
[modify] https://crrev.com/5e44786837d145a536811e26411f0484d0b2faaf/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/5e44786837d145a536811e26411f0484d0b2faaf/chrome/browser/background_fetch/background_fetch_delegate_impl.h
[modify] https://crrev.com/5e44786837d145a536811e26411f0484d0b2faaf/content/browser/background_fetch/background_fetch_delegate_proxy.cc
[modify] https://crrev.com/5e44786837d145a536811e26411f0484d0b2faaf/content/browser/background_fetch/background_fetch_delegate_proxy_unittest.cc
[modify] https://crrev.com/5e44786837d145a536811e26411f0484d0b2faaf/content/browser/background_fetch/mock_background_fetch_delegate.cc
[modify] https://crrev.com/5e44786837d145a536811e26411f0484d0b2faaf/content/browser/background_fetch/mock_background_fetch_delegate.h
[modify] https://crrev.com/5e44786837d145a536811e26411f0484d0b2faaf/content/public/browser/background_fetch_delegate.h

Comment 3 by na...@chromium.org, Jul 11

Status: Fixed (was: Started)
►

Sign in to add a comment