[Missing Test]:FIXME: Layer::requiresScrollableArea() const { return layoutBox(); } |
||
Issue descriptionAutomated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future? CL: ---- https://chromium.googlesource.com/chromium/src.git/+/1c6d2c62b7951ceba7ad78daf0cf22a7f28f07e6 Ref Bug: --------- https://bugs.chromium.org/p/chromium/issues/detail?id=467721 Thank you.
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcaed195338af4f060f3b02dfc657725db3b815f commit fcaed195338af4f060f3b02dfc657725db3b815f Author: Stephen McGruer <smcgruer@chromium.org> Date: Mon Oct 02 20:44:39 2017 Add test for changing ancestor overflow layer away from non-scrollable layer This tests the DCHECK fix that was applied in http://crrev.com/1c6d2c6 Bug: 467721 , 766140 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I96a2f0e608f4bb22a03e6e6845219de63fba2423 Reviewed-on: https://chromium-review.googlesource.com/668957 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#505773} [add] https://crrev.com/fcaed195338af4f060f3b02dfc657725db3b815f/third_party/WebKit/LayoutTests/fast/css/sticky/sticky-ancestor-scroller-changed.html [modify] https://crrev.com/fcaed195338af4f060f3b02dfc657725db3b815f/third_party/WebKit/Source/core/BUILD.gn [add] https://crrev.com/fcaed195338af4f060f3b02dfc657725db3b815f/third_party/WebKit/Source/core/paint/compositing/CompositingInputsUpdaterTest.cpp
,
Oct 2 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by smcgruer@chromium.org
, Sep 20 2017