Background Fetch in Incognito mode |
||||||||
Issue descriptionFrom: https://chromium-review.googlesource.com/c/chromium/src/+/647751/18 Since incognito must not be detectable due to the absence of Background Fetch, then depending on the permission model we end up with for Background Fetch we'll probably end up needing to override GetBrowserContextToUse here to return chrome::GetBrowserContextOwnInstanceInIncognito(context);. We'll additionally need to work with the Download Service to special case such downloads so that they are only stored in memory, and are aborted if/when the browser is exited.
,
Sep 18 2017
,
Sep 18 2017
,
Sep 21 2017
Adding privacy for FYI
,
Jan 24 2018
,
Apr 13 2018
,
Apr 20 2018
,
Aug 7
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c2fdfb867ef81d5f6d1e64579549f594310c948 commit 7c2fdfb867ef81d5f6d1e64579549f594310c948 Author: Rayan Kanso <rayankans@chromium.org> Date: Fri Aug 10 13:30:09 2018 [Background Fetch] Lazily initialize download service used by the delegate. If the storage partitions are not fully initialized, the delegate factory will enter an infinite loop when trying to create an instance of BackgroundFetchDelegateImpl. This changes moves the service initialization logic from the constructor to a lazy accessor function, which is guaranteed to be called after the IO thread is up and running. This means all Storage Partitions will have been loaded. This behavior can be triggered when creating a BackgroundFetchDelegateImpl in incognito mode. Bug: 766082 Change-Id: I320e146634792e16a61514620639ece38b022349 Reviewed-on: https://chromium-review.googlesource.com/1167842 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#582133} [modify] https://crrev.com/7c2fdfb867ef81d5f6d1e64579549f594310c948/chrome/browser/background_fetch/background_fetch_delegate_impl.cc [modify] https://crrev.com/7c2fdfb867ef81d5f6d1e64579549f594310c948/chrome/browser/background_fetch/background_fetch_delegate_impl.h
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d972720c6965f19ab0108a3b750c73da2805136c commit d972720c6965f19ab0108a3b750c73da2805136c Author: Rayan Kanso <rayankans@chromium.org> Date: Wed Aug 22 20:12:29 2018 [Background Fetch] Register Offline Item Aggregator in incognito mode Bug: 766082 Change-Id: Idd4a607177f0bbe44fac8dd9e7cd9fe357dbf4ef Reviewed-on: https://chromium-review.googlesource.com/1170906 Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#585219} [modify] https://crrev.com/d972720c6965f19ab0108a3b750c73da2805136c/chrome/browser/background_fetch/background_fetch_delegate_factory.cc [modify] https://crrev.com/d972720c6965f19ab0108a3b750c73da2805136c/chrome/browser/background_fetch/background_fetch_delegate_factory.h [modify] https://crrev.com/d972720c6965f19ab0108a3b750c73da2805136c/chrome/browser/background_fetch/background_fetch_delegate_impl.cc [modify] https://crrev.com/d972720c6965f19ab0108a3b750c73da2805136c/chrome/browser/background_fetch/background_fetch_delegate_impl.h [modify] https://crrev.com/d972720c6965f19ab0108a3b750c73da2805136c/chrome/browser/offline_items_collection/offline_content_aggregator_factory.cc
,
Sep 27
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by delph...@chromium.org
, Sep 18 2017