New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 766067 link

Starred by 2 users
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Sep 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ dschuyler@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Focus does not move to 'Customize fonts' icon on pressing Tab key.

Reported by avsha...@etouch.net, Sep 18 2017 
Chrome version : 63.0.3218.0 (Official Build) 8634c0eac009323c45c362e9308429d8f1e1976b-refs/heads/master@{#502516} 32/64 bit
OS : Windows (7,8,10), Linux(14.04)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://settings page.
2. In 'Appearance' section, open 'Font size' drop down list and hit Esc key to close it.
3. Now hit Tab key to move focus on 'Customize fonts' icon and observe.

Actual Result : Focus does not move to 'Customize fonts' icon on pressing Tab key.

Expected Result : The focus should move to 'Customize fonts' icon on pressing Tab key.

(Note : Need to press Tab key twice in order to move focus on 'Customize fonts' icon).

Correction : This issue is broken in ‘M-63’, below is the manual bisect info and will soon update remaining info.
Good build : 63.0.3213.0
Bad build : 63.0.3214.0
Actual_Result.mp4
1.0 MB View Download
Expected_Result.mp4
508 KB View Download

Comment 1 by avsha...@etouch.net, Sep 18 2017

Labels: hasbisect-per-revision Proj-MaterialDesign-WebUI
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build : 63.0.3213.0 (Revision:501133).
Bad build : 63.0.3214.0 (Revision:501490).

You are probably looking for a change made after 501393 (known good), but no later than 501394 (first known bad).

CHANGELOG URL: 
https://chromium.googlesource.com/chromium/src/+log/6a21639f7b4d135d70c4f664a261dc379a41477c..673e8a437f569bff9705e9b6e9883d25b795d384

Suspect : https://chromium.googlesource.com/chromium/src/+/673e8a437f569bff9705e9b6e9883d25b795d384

@dschuyler : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note : Issue is also reproducible on Mac(10.12.6, 10.12) OS using latest canary #63.0.3218.0.

Thank you!!

Comment 2 by dschuyler@chromium.org, Sep 18 2017

Cc: dschuyler@chromium.org
 Issue 766138  has been merged into this issue.

Comment 3 by dschuyler@chromium.org, Sep 19 2017

Status: Started (was: Assigned)
CL at https://chromium-review.googlesource.com/c/chromium/src/+/671198
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19192ca1fb559b64de7ccf679ab584f66f86a450

commit 19192ca1fb559b64de7ccf679ab584f66f86a450
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Thu Sep 21 21:10:07 2017

[cr webui] keyboard selection on cr-link-row

This CL fixes keyboard navigation to cr-link-row(s). A cr-icon class was
added for the purpose of creating cr-icons that are not within a button.

Bug:  766067 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I392a432c86313a81341deca4eda9e7505b5441e5
Reviewed-on: https://chromium-review.googlesource.com/671198
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503563}
[modify] https://crrev.com/19192ca1fb559b64de7ccf679ab584f66f86a450/ui/webui/resources/cr_elements/cr_icons_css.html
[modify] https://crrev.com/19192ca1fb559b64de7ccf679ab584f66f86a450/ui/webui/resources/cr_elements/cr_link_row/compiled_resources2.gyp
[modify] https://crrev.com/19192ca1fb559b64de7ccf679ab584f66f86a450/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html
[modify] https://crrev.com/19192ca1fb559b64de7ccf679ab584f66f86a450/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.js

Comment 5 by dschuyler@chromium.org, Sep 21 2017

Status: Fixed (was: Started)

Comment 6 by avsha...@etouch.net, Sep 22 2017

Labels: TE-Verified-M63 TE-Verified-63.0.3222.0
Update : 
Retested above issue in latest chrome canary #63.0.3222.0 on Windows(7,8,10), Mac(10.12.6) & Linux(14.04 LTS) OS and issue is fixed. Now focus moves on 'Customize fonts' icon on pressing Tab key.
Kindly review an attached screen cast.

Thank you!
Canary_behavior.mp4
744 KB View Download
►

Sign in to add a comment