New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 766066 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit 18 days ago
Closed: Jul 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 3
Type: Bug



Sign in to add a comment

Incognito window NTP background color not updated correctly for themes

Reported by vineetha...@etouch.net, Sep 18 2017

Issue description

Chrome version: 63.0.3218.0 (Official Build) 8634c0eac009323c45c362e9308429d8f1e1976b-refs/heads/master@{#502516}(32/64 bit).
OS: Windows(7,8,10) , Linux(14.04 LTS).

Steps to reproduce:
1.Launch chrome, Open at least 5 incognito windows.
2.Go to Wrench menu > Settings > Apply any theme from chrome web store twice
3.Go to Wrench menu > Settings > Appearance > Themes > click Reset to default and observe. 

Actual Result: Incognito windows flicker and turn unresponsive for some time on applying themes.
Expected Result: Incognito windows should not flicker and turn unresponsive.

This is Regression Issue broken in M-53 and and Using the per-revision bisect providing the bisect results,

Good Build: 53.0.2749.0(Revision:#396337)
Bad Build: 53.0.2750.0(Revision:#396054)

You are probably looking for a change made after 396300 (known good), but no later than 396306 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/e623eb7cd1fc6d7cef93a133c4742c42da96b76c..7b8323249aac91b1c7e51d880584fd102934cb7e

Suspect: https://chromium.googlesource.com/chromium/src/+/41e6f0e3e02a73b25cf08cad238f035730ca285e

@mariakhomenko : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

NOTE: Issue is not seen on MAC OS.

 
ActualResult.mp4
4.6 MB View Download
ExpectedResult.mp4
3.7 MB View Download
Owner: pkasting@chromium.org
Definitely not my change -- that's Android only.

Reassigning to pkasting@ based on descriptions in range this sounds more likely: https://chromium.googlesource.com/chromium/src/+/2676e97c1a42b7898fbc09176ab94b59bf1c421d
Components: -UI>Browser>Incognito
Labels: -Pri-2 -hasbisect-per-revision -M-63 Pri-3
Owner: est...@chromium.org
Summary: Incognito window NTP background color not updated correctly for themes (was: Incognito windows flicker and turn unresponsive on applying themes.)
I was able to reproduce a problem where incognito windows showing the NTP content ("you've gone incognito") didn't always update the background color/image correctly.  For example, if I open three incognito windows, install Nebula, and "Undo" the installation, I get one window with a dark grey background and two with white.  On re-installing the theme not all the windows got updated with the theme background too.

I did not see this occur with non-incognito windows.

I wasn't able to reproduce anything "unresponsive".  However, I did see at least the incognito windows seeming to flicker and change their Z-order as the theme was applied, which looked really janky.  Also, both normal and incognito windows only updated with the theme a second or so _after_ the theme installation UI showed the theme was installed, which seemed janky.

Evan is sort of the nominal theme owner at this point.  I will leave it to him to figure out what needs doing here.
Components: UI>Browser>NewTabPage
Labels: zine-triaged
Owner: sweilun@chromium.org
Weilun - I talked with Evan offline, and it looks like this one is up for grabs.

Please see if it's reproducible, and reach out to vineetha.sarma@ for more info. Thanks!
Status: WontFix (was: Assigned)
I have followed the steps to reproduce the problem both on Chrome and chromium without success. The bug is obsolete.

Sign in to add a comment