Rename RegisteredEventListener::listener() to callback() to match the specification
Reported by
bhagirat...@samsung.com,
Sep 18 2017
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0 Steps to reproduce the problem: Rename RegisteredEventListener::listener() to callback() for clarity and to match the specification. https://dom.spec.whatwg.org/#concept-event-listener What is the expected behavior? What went wrong? Rename RegisteredEventListener::listener() to callback() for clarity and to match the specification. https://dom.spec.whatwg.org/#concept-event-listener Did this work before? N/A Does this work in other browsers? N/A Chrome version: <Copy from: 'about:version'> Channel: n/a OS Version: Flash Version: Shockwave Flash 10.1 r999.<br>Gnash 0.8.11dev, the GNU SWF Player. Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 <a href="http://www.fsf.org">Free Software Foundation</a>, Inc. <br> Gnash comes with NO WARRANTY, to the extent permitted by law. You may redistribute copies of Gnash under the terms of the <a href="http://www.gnu.org/licenses/gpl.html">GNU General Public License</a>. For more information about Gnash, see <a href="http://www.gnu.org/software/gnash/"> http://www.gnu.org/software/gnash</a>. <br> Compatible Shockwave Flash 10.1 r999.
,
Sep 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c0cde82838e8e5f80db77d872e54d0af50f56cf commit 3c0cde82838e8e5f80db77d872e54d0af50f56cf Author: Bhagirathi Satpathy <bhagirathi.s@samsung.com> Date: Mon Sep 18 23:27:40 2017 Rename RegisteredEventListener::listener() to callback() to match the specification Rename RegisteredEventListener::listener() to callback() for clarity and to match the specification. https://dom.spec.whatwg.org/#concept-event-listener Bug: 766062 Change-Id: I9af2b09516ea6a7fd4fbfb5723e4280c5724793c Reviewed-on: https://chromium-review.googlesource.com/670906 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#502709} [modify] https://crrev.com/3c0cde82838e8e5f80db77d872e54d0af50f56cf/third_party/WebKit/Source/core/dom/events/EventListenerMap.cpp [modify] https://crrev.com/3c0cde82838e8e5f80db77d872e54d0af50f56cf/third_party/WebKit/Source/core/dom/events/EventTarget.cpp [modify] https://crrev.com/3c0cde82838e8e5f80db77d872e54d0af50f56cf/third_party/WebKit/Source/core/events/RegisteredEventListener.h [modify] https://crrev.com/3c0cde82838e8e5f80db77d872e54d0af50f56cf/third_party/WebKit/Source/core/html/media/MediaCustomControlsFullscreenDetectorTest.cpp [modify] https://crrev.com/3c0cde82838e8e5f80db77d872e54d0af50f56cf/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp [modify] https://crrev.com/3c0cde82838e8e5f80db77d872e54d0af50f56cf/third_party/WebKit/Source/core/svg/SVGElement.cpp
,
Sep 20 2017
Fixed with https://chromium-review.googlesource.com/670906.
,
Sep 25 2017
bhagirathi.s@ Could you please help us with the steps to verify this fix from TE-End.
,
Sep 25 2017
As per specification https://dom.spec.whatwg.org/#concept-event-listener, listener should be renamed to callback in RegisteredEventListener class which is made in https://chromium-review.googlesource.com/670906. There no steps to verify since it is implemented internally. As https://chromium-review.googlesource.com/670906 is already submitted, please close this issue.
,
Sep 25 2017
Thank you for providing more feedback. Adding requester "kkaluri@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 25 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bhagirat...@samsung.com
, Sep 18 2017