[MacViewsBrowser] Clicking on toolbar area takes away focus from Web
Reported by
jongkwon...@navercorp.com,
Sep 18 2017
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.0 Safari/537.36 Steps to reproduce the problem: 1. build chrome with mac_views_browser=1 and run 2. visit https://google.com 3. click on search box and see I-beam is blinking 4. click on toolbar area (bookmark bar, app menu, tab, etc) What is the expected behavior? I-beam continues blinking, i.e. search box retains focus. What went wrong? I-beam stops blinking, i.e. search box looses focus. Did this work before? No Chrome version: 62.0.3202.0 Channel: n/a OS Version: OS X 10.12.6 Flash Version:
,
Sep 18 2017
,
Sep 18 2017
Unable to build the Chrome with mac_views_browser=1 from our end, hence adding TE-Needs-TriageHelp label for further triage of the issue
,
Sep 18 2017
https://chromium-review.googlesource.com/c/chromium/src/+/670479
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9355bda6a5270dc2103caaf3e2de4ff08aa3ac0 commit d9355bda6a5270dc2103caaf3e2de4ff08aa3ac0 Author: jongkwon.lee <jongkwon.lee@navercorp.com> Date: Thu Sep 21 07:25:34 2017 Make acceptsFirstResponder returns NO BridgedContentView takes away focus from |web_contents| when it's clicked on mouse. So make it not accepts FirstResponder. Instead, make it first responder initially by NSWindow makeFirstResponder:. When other native view become first responder, it can again become first responder by it's views::View get focused due to NativeWidgetMac::ClearNativeFocus(). Bug: 766027 Test: Covered by existing focus manager tests. Change-Id: I12c68139e7d42c91aa1bca1b3485064d67d6823e Reviewed-on: https://chromium-review.googlesource.com/670479 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#503380} [modify] https://crrev.com/d9355bda6a5270dc2103caaf3e2de4ff08aa3ac0/ui/views/cocoa/bridged_content_view.mm [modify] https://crrev.com/d9355bda6a5270dc2103caaf3e2de4ff08aa3ac0/ui/views/widget/native_widget_mac.mm
,
Mar 23 2018
MacViews triage: this looks Fixed by #5. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nyerramilli@chromium.org
, Sep 18 2017