WebglConformance_conformance_extensions_oes_texture_half_float failing |
|||
Issue descriptionDuring this WebGL conformance roll: https://chromium-review.googlesource.com/669724 WebglConformance_conformance_extensions_oes_texture_half_float was found to fail on: - Android - Linux with the pass-through command decoder - Windows with the pass-through command decoder https://luci-milo.appspot.com/buildbot/tryserver.chromium.android/android_optional_gpu_tests_rel/10295 https://luci-milo.appspot.com/buildbot/tryserver.chromium.linux/linux_optional_gpu_tests_rel/13152 https://luci-milo.appspot.com/buildbot/tryserver.chromium.win/win_optional_gpu_tests_rel/14585 Suppressing these failures. Mo, could you please take a look?
,
Sep 17 2017
I think I understand why it's failing on pass-through command buffer and the fix is trivia. However, I need to debug into Android build to understand why it's also failing there.
,
Sep 19 2017
The Android failure is caused by ES3 extension behaviors. On ES3, internally we check RGBA16F/RGBA/HALF_FLOAT render-ability and expose the extension. However, when truly allocate a RGBA/RGBA/HALF_FLOAT_OES texture, we don't map it to RGBA16F/RGBA/HALF_FLOAT. Interestingly, although Android ES3 drivers do report OES_color_buffer_half_float, RGBA16F/RGBA/HALF_FLOAT is color-renderable, but RGBA/RGBA/HALF_FLOAT_OES is not. So the fix is to always do the mapping to sized formats on ES3.
,
Sep 19 2017
CL is here: https://chromium-review.googlesource.com/c/chromium/src/+/671843
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c82b9b9ae2998c45d755bf400f0fb07c17275e97 commit c82b9b9ae2998c45d755bf400f0fb07c17275e97 Author: Zhenyao Mo <zmo@chromium.org> Date: Tue Sep 26 01:27:03 2017 Fix EXT_color_buffer_half_float behavior on passthrough command buffer and Android. This also includes a WebGL conformance roll. BUG= 765953 TEST=webgl conformance R=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I166bada31aefac271e145a545f82975bc3a0dfed Reviewed-on: https://chromium-review.googlesource.com/671843 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#504250} [modify] https://crrev.com/c82b9b9ae2998c45d755bf400f0fb07c17275e97/DEPS [modify] https://crrev.com/c82b9b9ae2998c45d755bf400f0fb07c17275e97/content/test/gpu/gpu_tests/webgl_conformance_expectations.py [modify] https://crrev.com/c82b9b9ae2998c45d755bf400f0fb07c17275e97/content/test/gpu/gpu_tests/webgl_conformance_revision.txt [modify] https://crrev.com/c82b9b9ae2998c45d755bf400f0fb07c17275e97/gpu/command_buffer/service/context_group.cc [modify] https://crrev.com/c82b9b9ae2998c45d755bf400f0fb07c17275e97/gpu/command_buffer/service/feature_info.cc [modify] https://crrev.com/c82b9b9ae2998c45d755bf400f0fb07c17275e97/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/c82b9b9ae2998c45d755bf400f0fb07c17275e97/gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc [modify] https://crrev.com/c82b9b9ae2998c45d755bf400f0fb07c17275e97/gpu/command_buffer/service/test_helper.cc [modify] https://crrev.com/c82b9b9ae2998c45d755bf400f0fb07c17275e97/third_party/WebKit/Source/modules/webgl/OESTextureHalfFloat.cpp [modify] https://crrev.com/c82b9b9ae2998c45d755bf400f0fb07c17275e97/ui/gl/gl_gl_api_implementation.cc [modify] https://crrev.com/c82b9b9ae2998c45d755bf400f0fb07c17275e97/ui/gl/gl_gl_api_implementation.h
,
Sep 26 2017
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/c71ea661e371833f4c20a19cbcd6936d5b3024e6 commit c71ea661e371833f4c20a19cbcd6936d5b3024e6 Author: Geoff Lang <geofflang@chromium.org> Date: Tue Sep 26 22:07:15 2017 Return HALF_FLOAT as an implementation read type in ES3. BUG= 765953 Change-Id: I4dc79921766975cd75c489887b7e57ec4666fbbb Reviewed-on: https://chromium-review.googlesource.com/685897 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> [modify] https://crrev.com/c71ea661e371833f4c20a19cbcd6936d5b3024e6/src/libANGLE/renderer/d3d/FramebufferD3D.cpp [modify] https://crrev.com/c71ea661e371833f4c20a19cbcd6936d5b3024e6/src/libANGLE/formatutils.cpp [modify] https://crrev.com/c71ea661e371833f4c20a19cbcd6936d5b3024e6/src/libANGLE/renderer/gl/FramebufferGL.cpp [modify] https://crrev.com/c71ea661e371833f4c20a19cbcd6936d5b3024e6/src/libANGLE/formatutils.h [modify] https://crrev.com/c71ea661e371833f4c20a19cbcd6936d5b3024e6/src/libANGLE/renderer/null/FramebufferNULL.cpp
,
Sep 28 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/4b050009067044ad9352d26013c10991bda38f91 commit 4b050009067044ad9352d26013c10991bda38f91 Author: Geoff Lang <geofflang@google.com> Date: Thu Sep 28 20:43:42 2017 Always read half-float textures as GL_HALF_FLOAT in ES3. ANGLE now returns GL_HALF_FLOAT as the GL_IMPLEMENTATION_READ_TYPE for ES3 contexts. BUG= 765953 CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE Change-Id: I556aecc040f0274b769a3b551b7032adf4ab035a Reviewed-on: https://skia-review.googlesource.com/52523 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com> [modify] https://crrev.com/4b050009067044ad9352d26013c10991bda38f91/DEPS [modify] https://crrev.com/4b050009067044ad9352d26013c10991bda38f91/src/gpu/gl/GrGLCaps.cpp
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a53f708beadbc5dfb05b803ab4c81744e7a105e0 commit a53f708beadbc5dfb05b803ab4c81744e7a105e0 Author: Yuly Novikov <ynovikov@chromium.org> Date: Thu Sep 28 21:50:29 2017 Roll ANGLE 1f9d684..db34227 https://chromium.googlesource.com/angle/angle.git/+log/1f9d684..db34227 BUG= 765953 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I8d37a0c02d9b31b6598b5acdbc296ecfb518dc14 Reviewed-on: https://chromium-review.googlesource.com/690520 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#505174} [modify] https://crrev.com/a53f708beadbc5dfb05b803ab4c81744e7a105e0/DEPS
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/306c7ea76432f773dc2be67b82d756faf9bcbbbe commit 306c7ea76432f773dc2be67b82d756faf9bcbbbe Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Thu Sep 28 22:53:50 2017 Roll src/third_party/skia/ 097900648..8b059bd94 (17 commits; 1 trivial rolls) https://skia.googlesource.com/skia.git/+log/097900648b0b..8b059bd946d9 $ git log 097900648..8b059bd94 --date=short --no-merges --format='%ad %ae %s' 2017-09-28 egdaniel Revert "Update GrBitmapTextureMaker for handling mipped requests" 2017-09-28 geofflang Always read half-float textures as GL_HALF_FLOAT in ES3. 2017-09-28 herb Reorganize blur filter to insert new implementation 2017-09-28 scroggo Avoid uninitialized memory in readByteArrayAsData 2017-09-28 jvanverth Miscellaneous dynamic atlas fixes. 2017-09-28 egdaniel Update GrBitmapTextureMaker for handling mipped requests 2017-09-28 csmartdalton Remove tolerance form SkClassifyCubic 2017-09-28 csmartdalton CCPR: Handle very large paths 2017-09-28 csmartdalton Add svg support to pathfinder tool 2017-09-27 mtklein Move context types into STAGE() macros. 2017-09-28 cblume Remove unused param to SkGIFFrameContext ctor 2017-09-28 brianosman Revert "Revert "Revert "Make threaded proxy generation MDB-friendly, and defer instantiation""" 2017-09-27 mtklein Always zero vectors in start_pipeline(). 2017-09-28 benjaminwagner Fix job name in PRESUBMIT.py. 2017-09-28 brianosman Revert "Revert "Make threaded proxy generation MDB-friendly, and defer instantiation"" 2017-09-28 mtklein Also mask t itself in mask_2pt_conical_degenerates. Created with: roll-dep src/third_party/skia BUG= 765953 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Idc039c79f9de9af429654c315f8742fb4e1e4013 Reviewed-on: https://chromium-review.googlesource.com/691076 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505199} [modify] https://crrev.com/306c7ea76432f773dc2be67b82d756faf9bcbbbe/DEPS
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5510b2ff0dafcf4e697a6aa43f9ccf64017e6ad5 commit 5510b2ff0dafcf4e697a6aa43f9ccf64017e6ad5 Author: Zhenyao Mo <zmo@chromium.org> Date: Tue Oct 03 19:30:19 2017 Simplify ReadPixels with HALF_FLOAT/HALF_FLOAT_OES type. Now ANGLE changes its behavior to always return HALF_FLOAT in ES3. BUG= 765953 TEST=bots R=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie1c692e45b6d3cbf3d2eec031cbafb0b33d68dd3 Reviewed-on: https://chromium-review.googlesource.com/691283 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#506141} [modify] https://crrev.com/5510b2ff0dafcf4e697a6aa43f9ccf64017e6ad5/ui/gl/gl_gl_api_implementation.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Sep 17 2017