org.chromium.android_webview.test.SafeBrowsingTest#testSafeBrowsingOnSafeBrowsingHitForSubresource__multiprocess_mode flake on android_n5x_swarming_rel |
|||||||||||||
Issue descriptionFailure seen during webview_instrumentation_test_apk run in this tryjob: https://luci-milo.appspot.com/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/263817 of this unrelated CL: https://chromium-review.googlesource.com/c/chromium/src/+/669842 Other similar failures including testSafeBrowsingOnSafeBrowsingHitForSubresource : https://luci-milo.appspot.com/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/263876 https://luci-milo.appspot.com/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/263834 Log excerpt: java.lang.AssertionError: Target page should be visible expected:<-16119286> but was:<-16711936> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:645) at org.chromium.android_webview.test.SafeBrowsingTest.assertTargetPageHasLoaded(SafeBrowsingTest.java:409) at org.chromium.android_webview.test.SafeBrowsingTest.testSafeBrowsingOnSafeBrowsingHitForSubresource(SafeBrowsingTest.java:851) at java.lang.reflect.Method.invoke(Native Method) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.chromium.android_webview.test.AwActivityTestRule$1.evaluate(AwActivityTestRule.java:55) at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55) at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270) ...
,
Sep 18 2017
,
Sep 21 2017
Thanks, I'll take a look.
,
Sep 21 2017
So it looks like we're trying to navigate from the green page to the iframe page, with no interstitial showing up. Even though we wait for VisualStateCallback, it looks like the page is still green. It's not obvious to me why that isn't OK. I'll investigate more.
,
Sep 27 2017
,
Sep 27 2017
This doesn't seem to flake very often, so I'll try adding @retryonfailure.
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24e28c227780d577bd286272e0aefbcdea449838 commit 24e28c227780d577bd286272e0aefbcdea449838 Author: Nate Fischer <ntfschr@chromium.org> Date: Wed Sep 27 23:41:12 2017 AW: add RetryOnFailure to flaky test This adds @RetryOnFailure to a flaky Safe Browsing test. This does not flake very often. Bug: 765932 Change-Id: Ic7bc40863d395b76c821ee9c277b17d82e5c5ff4 Reviewed-on: https://chromium-review.googlesource.com/688676 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#504804} [modify] https://crrev.com/24e28c227780d577bd286272e0aefbcdea449838/android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java
,
Sep 29 2017
,
Oct 11 2017
,
Nov 10 2017
,
Nov 29 2017
,
Feb 18 2018
,
Apr 14 2018
I looked at the most recent flakes [1], and I believe these to be the result of an infra failure: * the flakes are clumped together in batches, with long periods of no flakes (2/01-2/02, 3/02-3/16) * unrelated WebView tests failed in the same batch * the failures are isolated to shard #7 I believe the device on shard #7 occasionally falls into a bad state, gets fixed, but eventually falls back into the same bad state (e.g., screen off, crash dialog on screen). I think we can revert 24e28c227780d577bd286272e0aefbcdea449838, since this particular test doesn't appear inherently flaky. I'm switching this from WebView/SafeBrowsing -> Infra. Adding some Infra people in case they think there's a way to fix shard #7. I'll unassign once I revert the previous commit. [1] https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybQsSBUZsYWtlImJvcmcuY2hyb21pdW0uYW5kcm9pZF93ZWJ2aWV3LnRlc3QuU2FmZUJyb3dzaW5nVGVzdCN0ZXN0U2FmZUJyb3dzaW5nT25TYWZlQnJvd3NpbmdIaXRGb3JTdWJyZXNvdXJjZQw
,
Apr 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56ac11c353038ec2e5bdacbc5022a96b4be3ef23 commit 56ac11c353038ec2e5bdacbc5022a96b4be3ef23 Author: Nate Fischer <ntfschr@chromium.org> Date: Sat Apr 14 03:17:29 2018 Revert "AW: add RetryOnFailure to flaky test" This reverts commit 24e28c227780d577bd286272e0aefbcdea449838. Reason for revert: This appears to be due to infra flakes Original change's description: > AW: add RetryOnFailure to flaky test > > This adds @RetryOnFailure to a flaky Safe Browsing test. This does not > flake very often. > > Bug: 765932 > Change-Id: Ic7bc40863d395b76c821ee9c277b17d82e5c5ff4 > Reviewed-on: https://chromium-review.googlesource.com/688676 > Commit-Queue: Nate Fischer <ntfschr@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504804} TBR=boliu@chromium.org,ntfschr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 765932 Change-Id: Ia9a3e06eed325ab486b3d31468e4d04578c30438 Reviewed-on: https://chromium-review.googlesource.com/1013267 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550872} [modify] https://crrev.com/56ac11c353038ec2e5bdacbc5022a96b4be3ef23/android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java
,
Apr 14 2018
,
Apr 16 2018
From the post test screenshots, it looks like all the screens are off in the failed tests. Yeah, that's probably infra flake. Though according to https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybQsSBUZsYWtlImJvcmcuY2hyb21pdW0uYW5kcm9pZF93ZWJ2aWV3LnRlc3QuU2FmZUJyb3dzaW5nVGVzdCN0ZXN0U2FmZUJyb3dzaW5nT25TYWZlQnJvd3NpbmdIaXRGb3JTdWJyZXNvdXJjZQw all most recent flakes are from over a month ago? That pretty old. I'll just wontfix this unless someone objects.
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56ac11c353038ec2e5bdacbc5022a96b4be3ef23 commit 56ac11c353038ec2e5bdacbc5022a96b4be3ef23 Author: Nate Fischer <ntfschr@chromium.org> Date: Sat Apr 14 03:17:29 2018 Revert "AW: add RetryOnFailure to flaky test" This reverts commit 24e28c227780d577bd286272e0aefbcdea449838. Reason for revert: This appears to be due to infra flakes Original change's description: > AW: add RetryOnFailure to flaky test > > This adds @RetryOnFailure to a flaky Safe Browsing test. This does not > flake very often. > > Bug: 765932 > Change-Id: Ic7bc40863d395b76c821ee9c277b17d82e5c5ff4 > Reviewed-on: https://chromium-review.googlesource.com/688676 > Commit-Queue: Nate Fischer <ntfschr@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504804} TBR=boliu@chromium.org,ntfschr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 765932 Change-Id: Ia9a3e06eed325ab486b3d31468e4d04578c30438 Reviewed-on: https://chromium-review.googlesource.com/1013267 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#550872} [modify] https://crrev.com/56ac11c353038ec2e5bdacbc5022a96b4be3ef23/android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by kbr@chromium.org
, Sep 16 2017