New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 765919 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: glGetError() == GL_NO_ERROR in feature_info.cc

Project Member Reported by ClusterFuzz, Sep 16 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6016320872382464

Fuzzer: libFuzzer_gpu_angle_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  glGetError() == GL_NO_ERROR in feature_info.cc
  base::debug::DebugBreak
  gpu::gles2::IsGL_REDSupportedOnFBOs
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=469306:469316

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6016320872382464

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: msrchandra@chromium.org kkaluri@chromium.org
Components: Internals>GPU
Labels: M-61 Test-Predator-Wrong-CLs
Owner: geoffl...@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using Code Search for the file, "feature_info.cc" assigning to the concern owner who might be related or worked on similar file.

Suspect CL: https://chromium.googlesource.com/chromium/src/+/bb607f63e67703f32881fa11e9d20d53878b00e8

geofflang@ -- Could you please look into the issue, kindly re-assign if this is not related to your changes.


Thank You.
Project Member

Comment 2 by ClusterFuzz, Oct 1 2017

Components: Internals>GPU>Internals
Labels: Test-Predator-AutoComponents
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/23e028432c682454f0b52c2443f2c057a2ed4559

commit 23e028432c682454f0b52c2443f2c057a2ed4559
Author: Geoff Lang <geofflang@chromium.org>
Date: Wed Oct 18 20:35:12 2017

Only validate texture layer if texture is non-zero.

From the ES3.0 spec:
The error INVALID_VALUE is generated if texture is non-zero and layer
is negative.

BUG= 765919 

Change-Id: I0ac9bd0335ab4d55701d6def0158297d5add993e
Reviewed-on: https://chromium-review.googlesource.com/723741
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

[modify] https://crrev.com/23e028432c682454f0b52c2443f2c057a2ed4559/src/libANGLE/validationES3.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/aa5c70636f61d91830a234ee0b157c33bb6c05ae

commit aa5c70636f61d91830a234ee0b157c33bb6c05ae
Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org>
Date: Thu Oct 19 02:44:45 2017

Roll skia/third_party/externals/angle2/ d0ef13a25..23e028432 (1 commit)

https://chromium.googlesource.com/angle/angle.git/+log/d0ef13a2505f..23e028432c68

$ git log d0ef13a25..23e028432 --date=short --no-merges --format='%ad %ae %s'
2017-10-17 geofflang Only validate texture layer if texture is non-zero.

Created with:
  roll-dep skia/third_party/externals/angle2
BUG= 765919 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE
TBR=benjaminwagner@google.com

Change-Id: Ia936b477bc23407cbba798c68a36f87ee5a44ff2
Reviewed-on: https://skia-review.googlesource.com/61644
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>

[modify] https://crrev.com/aa5c70636f61d91830a234ee0b157c33bb6c05ae/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0db6295e40ac5be7e4cd97d62783ce00727d5043

commit 0db6295e40ac5be7e4cd97d62783ce00727d5043
Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org>
Date: Thu Oct 19 03:58:40 2017

Roll src/third_party/skia/ eac03014e..aa5c70636 (1 commit)

https://skia.googlesource.com/skia.git/+log/eac03014e564..aa5c70636f61

$ git log eac03014e..aa5c70636 --date=short --no-merges --format='%ad %ae %s'
2017-10-18 angle-deps-roller Roll skia/third_party/externals/angle2/ d0ef13a25..23e028432 (1 commit)

Created with:
  roll-dep src/third_party/skia
BUG= 765919 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: Ide992249b98f15365bde945b35d0da5c595a721c
Reviewed-on: https://chromium-review.googlesource.com/726824
Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509993}
[modify] https://crrev.com/0db6295e40ac5be7e4cd97d62783ce00727d5043/DEPS

Project Member

Comment 6 by ClusterFuzz, Oct 19 2017

ClusterFuzz has detected this issue as fixed in range 509892:509921.

Detailed report: https://clusterfuzz.com/testcase?key=6016320872382464

Fuzzer: libFuzzer_gpu_angle_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  glGetError() == GL_NO_ERROR in feature_info.cc
  gpu::gles2::IsGL_REDSupportedOnFBOs
  gpu::gles2::FeatureInfo::InitializeFeatures
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=469306:469316
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=509892:509921

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6016320872382464

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Oct 19 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6016320872382464 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3207257903041bf675be53839397d16a5c72cc82

commit 3207257903041bf675be53839397d16a5c72cc82
Author: Frank Henigman <fjhenigman@chromium.org>
Date: Thu Oct 19 18:00:23 2017

Roll ANGLE d042fba..cbcb96f

https://chromium.googlesource.com/angle/angle.git/+log/d042fba..cbcb96f

BUG= 765919 

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: Ie29f5ce96fd63f1c1f9c51a5646cfa5da12d17f6
Reviewed-on: https://chromium-review.googlesource.com/726756
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510135}
[modify] https://crrev.com/3207257903041bf675be53839397d16a5c72cc82/DEPS

Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components

Sign in to add a comment