New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 765913 link

Starred by 1 user
Status: Fixed
Owner:
zmo@chromium.org
Closed: Sep 2017
Cc:
ynovikov@chromium.org
█ kbr@chromium.org
jmad...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

depth_capture_tests failing on Nexus 5 GPU FYI bot

Project Member Reported by jmad...@chromium.org, Sep 16 2017 
First failing build:

https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%205%29/builds/7327

Unexpected Failures:
* gpu_tests.depth_capture_integration_test.DepthCaptureIntegrationTest.DepthCapture_depthStreamToR32FloatTexture

Chromium regression range:

https://chromium.googlesource.com/chromium/src/+log/b346b061e76..9108eeb3

Mo, could this have anything to do with your GPU info collection change:

"Move WebGL blacklist decision making to GPU process."

https://chromium-review.googlesource.com/659100

Unsure of what else to suspect.

Comment 1 by zmo@chromium.org, Sep 16 2017

Status: Available (was: Untriaged)
Yes, it looks my CL triggers the failure. What I don't understand is how it passed before.  The test requires WebGL2 to run. Looking at status, even before my CL, WebGL2 is off (because we disable depth texture on that device due to driver bug), so it should always fail. So it's an error that it passed before.

We simply need to mark this test as fail (or change the test to pass if WebGL2 isn't available).

Comment 2 by zmo@chromium.org, Sep 16 2017

Summary: depth_capture_tests failing on Nexus 5 GPU FYI bot (was: depth_capture_tests failing on Nexus 5x GPU FYI bot)
It's Nexus 5 bot, not Nexus 5x bot
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de1fbac56080d0e1ecdf5cbc7fe526a834437a86

commit de1fbac56080d0e1ecdf5cbc7fe526a834437a86
Author: Zhenyao Mo <zmo@chromium.org>
Date: Sun Sep 17 22:28:16 2017

Suppress DepthCapture_depthStreamToR32FloatTexture on Android Nexus 5

This test shouldn't have passed before, so before there was a bug that WebGL2
wasn't blacklisted as it should have been. My CL actually fixed the bug so
this test began to fail, which is expected correct behavior.

BUG= 765913 
TEST=Nexus 5 bot green on GPU FYI waterfall
TBR=jmadill@chromium.org,kbr@chromium.org
NOTRY=true

Change-Id: Ia31ad22e7339c28460c143c108d82dfb9a998d48
Reviewed-on: https://chromium-review.googlesource.com/669487
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502527}
[modify] https://crrev.com/de1fbac56080d0e1ecdf5cbc7fe526a834437a86/content/test/gpu/gpu_tests/depth_capture_expectations.py

Comment 4 by zmo@chromium.org, Sep 17 2017

Cc: -zmo@chromium.org
Owner: zmo@chromium.org
Status: Fixed (was: Available)

Comment 5 by jmad...@chromium.org, Sep 17 2017 

Thanks for fixing Mo, and for correcting the title.
►

Sign in to add a comment