OOP HP: profiling process does not clean up after dead renderers. |
||
Issue descriptionIn --memlog=all mode, when a renderer dies, the AllocationTracker is destroyed, but all the atoms inserted into BacktraceStorage still exist. Given that renderers have jitted code, this suggests that many/most atoms will be unique, and this will cause the profiling process to grow unbounded.
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be39ab37dcca3e7675cd2eea6002ae11ee06688f commit be39ab37dcca3e7675cd2eea6002ae11ee06688f Author: Brett Wilson <brettw@chromium.org> Date: Wed Sep 20 18:31:03 2017 Fix leak of allocations in OOP memory logging. Previously at process exit all allocations and backtraces would be leaked due to an errant release() call on the pointer. Bug: 765863 Change-Id: Iff4c320e40e58adb417e41a49ea2199a2e5d48ba Reviewed-on: https://chromium-review.googlesource.com/675569 Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#503208} [modify] https://crrev.com/be39ab37dcca3e7675cd2eea6002ae11ee06688f/chrome/profiling/memlog_connection_manager.cc
,
Sep 20 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by erikc...@chromium.org
, Sep 19 2017