New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 765853 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Move PowerButtonController::OnDisplayModeChanged to PowerButtonDisplayController

Project Member Reported by warx@chromium.org, Sep 15 2017

Issue description

OnDisplayModeChanged sounds like an implementation of PowerButtonDisplayController.

I will also move screenshot function out of power button controller. IMO, power button controller should be a place for
(1) creating sub-controllers for specific tasks.
(2) triaging events, and by default clamshell power button behavior.
 

Comment 1 by warx@chromium.org, Nov 8 2017

Status: WontFix (was: Assigned)
PowerButtonController::OnDisplayModeChanged is strongly related to clamshell locking. Let us still keep it in PowerButtonController.

Sign in to add a comment