New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 765842 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 765834



Sign in to add a comment

[Predator] Add component path to those component build testcases.

Project Member Reported by kateso...@chromium.org, Sep 15 2017

Issue description

[Predator] Add component path to those stand-alone component build testcases.

For a d8 build like this https://findit-for-me.googleplex.com/clusterfuzz/result-feedback?key=ahpzfmdvb2dsZS5jb206ZmluZGl0LWZvci1tZXJBCxITQ2x1c3RlcmZ1enpBbmFseXNpcyIoNTU4MDQ0NjdiMmQ2NGFlMWMxNmUyMTBmNDZiMWUyYTE0Y2UzYjg1Zgw


We should insert 'src/v8' in the front of the file paths.
 
Description: Show this description
Labels: -Pri-3 Pri-1
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ec84c8fc71cb1ba99d0eb149eb8339844746f1d0

commit ec84c8fc71cb1ba99d0eb149eb8339844746f1d0
Author: Sharu Jiang <katesonia@google.com>
Date: Sat Sep 30 01:10:54 2017

[Predator] Use repo_to_dep_path in config to find components.

The repo_to_dep_path in config is like this:
{
  "https://boringssl.googlesource.com/boringssl.git": "src/third_party/boringssl/src",
  "https://chromium.googlesource.com/android_tools.git": "src/third_party/android_tools",
  "https://chromium.googlesource.com/angle/angle.git": "src/third_party/angle",
  "https://chromium.googlesource.com/aosp/platform/system/core/libsync.git": "src/third_party/libsync/src",
  ...
}
By using this mapping, we can easily map repo_url to dep_path relative to chromium. So this method will work for component stand alone builds, like d8.

Bug:  765842 
Change-Id: I5a7de0d46568cf142436e728d6ca6d484a190304
Reviewed-on: https://chromium-review.googlesource.com/685942
Commit-Queue: Sharu Jiang <katesonia@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/ec84c8fc71cb1ba99d0eb149eb8339844746f1d0/appengine/predator/analysis/component_classifier.py
[modify] https://crrev.com/ec84c8fc71cb1ba99d0eb149eb8339844746f1d0/appengine/predator/analysis/predator.py
[modify] https://crrev.com/ec84c8fc71cb1ba99d0eb149eb8339844746f1d0/appengine/predator/analysis/linear/changelist_features/test/touch_crashed_component_test.py
[modify] https://crrev.com/ec84c8fc71cb1ba99d0eb149eb8339844746f1d0/appengine/predator/app/common/predator_app.py
[modify] https://crrev.com/ec84c8fc71cb1ba99d0eb149eb8339844746f1d0/appengine/predator/analysis/test/component_classifier_test.py

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/5d6cbd3dc5afda9fe393c6c7f4653528026f7534

commit 5d6cbd3dc5afda9fe393c6c7f4653528026f7534
Author: Sharu Jiang <katesonia@google.com>
Date: Sat Sep 30 01:26:54 2017

[Predator] Pass root repository path and root repository url to GetDepPathAndNormalizedFilePath normalize paths.

For d8 stand-alone builds, we should pass 'v8' as root path instead of the 'src' for chromium build.

Bug:  765842 
Change-Id: I5995b63a9a9e669065306d87d08c67e0d16856c4
Reviewed-on: https://chromium-review.googlesource.com/685543
Commit-Queue: Sharu Jiang <katesonia@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/5d6cbd3dc5afda9fe393c6c7f4653528026f7534/appengine/predator/app/common/model/crash_analysis.py
[modify] https://crrev.com/5d6cbd3dc5afda9fe393c6c7f4653528026f7534/appengine/predator/app/common/model/test/clusterfuzz_analysis_test.py
[add] https://crrev.com/5d6cbd3dc5afda9fe393c6c7f4653528026f7534/appengine/predator/analysis/constants.py
[modify] https://crrev.com/5d6cbd3dc5afda9fe393c6c7f4653528026f7534/appengine/predator/analysis/crash_report.py
[modify] https://crrev.com/5d6cbd3dc5afda9fe393c6c7f4653528026f7534/appengine/predator/app/common/model/clusterfuzz_analysis.py
[modify] https://crrev.com/5d6cbd3dc5afda9fe393c6c7f4653528026f7534/appengine/predator/app/common/model/test/crash_analysis_test.py
[modify] https://crrev.com/5d6cbd3dc5afda9fe393c6c7f4653528026f7534/appengine/predator/analysis/parse_util.py

Status: Fixed (was: Assigned)

Sign in to add a comment