New issue
Advanced search Search tips

Issue 765802 link

Starred by 1 user
Status: WontFix
Owner:
timvolod...@chromium.org
Closed: Sep 2017
Cc:
reillyg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Check necessity of casts-to-double introduced during cleanup

Project Member Reported by pkasting@chromium.org, Sep 15 2017 
https://chromium-review.googlesource.com/c/chromium/src/+/657905 switches some code to use common methods for deg/rad conversion.  

In order to avoid changing existing behavior, casts to double were inserted in:
  device/sensors/data_fetcher_shared_memory_mac.cc:FetchOrientation()
  SensorManagerChromeOS::GenerateOrientationEvent()

If it doesn't meaningfully affect precision, these should be removed.  Ideally, we should have tests that verify the behavior here and detect any meaningful precision changes.

Comment 1 by reillyg@chromium.org, Sep 16 2017

Status: WontFix (was: Assigned)
Marking this WontFix as juncai@'s refactoring of the DeviceOrientation Events API means that //device/sensors will soon be deleted and //services/device/generic_sensor will completely take its place.

Comment 2 by pkasting@chromium.org, Sep 20 2017 

OK; the CL still has TODOs that reference this bug, which I'll just leave.  That way as long as the directory gets deleted they'll disappear, and if for some reason it doesn't, people seeing them will look at this bug and say "hey, why didn't that happen".
►

Sign in to add a comment