PeripheralBatteryNotifierTest failing on chromium.chromiumos/Linux ChromiumOS Tests (1) |
|||||
Issue descriptionash_unittests-mash failing on chromium.chromiumos/Linux ChromiumOS Tests (1) Test Failed: PeripheralBatteryNotifierTest.DeviceRemove PeripheralBatteryNotifierTest.StylusNotification Builders failed on: - Linux ChromiumOS Tests (1): https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29 Failure Log: message_center->FindVisibleNotificationById( PeripheralBatteryNotifier::kStylusNotificationId) != nullptr
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d4ef3f06ce689078bb9d29c8fc648a8de5df2af commit 3d4ef3f06ce689078bb9d29c8fc648a8de5df2af Author: kelvinp@chromium.org <kelvinp@chromium.org> Date: Fri Sep 15 21:09:37 2017 Disable failing PeripheralBatteryNotifierTest TBR=jennyz@chromium.org Bug: 765794 Change-Id: I708dd1e3e9cbd0d6d1f0399710869fa1dc4e026d No-Try: true Reviewed-on: https://chromium-review.googlesource.com/669312 Commit-Queue: Kelvin Poon <kelvinp@chromium.org> Reviewed-by: Kelvin Poon <kelvinp@chromium.org> Cr-Commit-Position: refs/heads/master@{#502371} [modify] https://crrev.com/3d4ef3f06ce689078bb9d29c8fc648a8de5df2af/ash/system/power/peripheral_battery_notifier_unittest.cc
,
Sep 15 2017
-Sheriff-Chromium as the test is disabled.
,
Oct 24 2017
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a92a232a5b1616c352ef3c332242d7422daa9916 commit a92a232a5b1616c352ef3c332242d7422daa9916 Author: Sammie Quon <sammiequon@google.com> Date: Tue Nov 07 22:29:13 2017 ash: Renable PeripheralBatteryNotifier tests. Passed locally after running 12000 times and dry-ran 10 times and counting. Test: ash_unittests PeripheralBatteryNotifierTest.* Bug: 765794 Change-Id: Ia7ad401eab3be0e2ae3a017da00296a1aee66376 Reviewed-on: https://chromium-review.googlesource.com/734706 Reviewed-by: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#514622} [modify] https://crrev.com/a92a232a5b1616c352ef3c332242d7422daa9916/ash/system/power/peripheral_battery_notifier_unittest.cc
,
Nov 16 2017
This test is flaky on ash_unittests-mus (ash_unittests --mus). Maybe there is a problem with notifications? Maybe something is async that used to be synchronous and it needs to wait? [ RUN ] PeripheralBatteryNotifierTest.DeviceRemove ../../ash/system/power/peripheral_battery_notifier_unittest.cc:178: Failure Value of: message_center->FindVisibleNotificationById(kTestBatteryPath) != nullptr Actual: false Expected: true
,
Nov 16 2017
(sample failure https://ci.chromium.org/buildbot/chromium.fyi/Mojo%20ChromiumOS/24380 )
,
Nov 21 2017
PeripheralBatteryNotifierTest.DeviceRemove in ash_unittests-mus is flaky also on "linux-chromeos-rel" bot https://build.chromium.org/p/chromium.chromiumos/builders/linux-chromeos-rel/builds/2736 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2Flinux-chromeos-rel%2F2736%2F%2B%2Frecipes%2Fsteps%2Fash_unittests-mus%2F0%2Flogs%2FPeripheralBatteryNotifierTest.DeviceRemove%2F0 https://build.chromium.org/p/chromium.chromiumos/builders/linux-chromeos-rel/builds/2790 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2Flinux-chromeos-rel%2F2790%2F%2B%2Frecipes%2Fsteps%2Fash_unittests-mus%2F0%2Flogs%2FPeripheralBatteryNotifierTest.DeviceRemove%2F0
,
Nov 27 2017
sammiequon@, are you looking into this? If not, I'll revert the CL in #5
,
Nov 27 2017
looking at now, it seems it is not flaky for StylusNotification, i will only disable DeviceRemove.
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a88afd250c0e0f76c485358fa8ed621cd20c858f commit a88afd250c0e0f76c485358fa8ed621cd20c858f Author: Sammie Quon <sammiequon@google.com> Date: Tue Nov 28 18:43:29 2017 ash: Disable PeripheralBatteryNotifierTest.DeviceRemove. Flaky on --mus. Test: none Bug: 765794 Change-Id: I7b5ccaeb2da6ebbb233c33ece7fb813949c99bec Reviewed-on: https://chromium-review.googlesource.com/791522 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#519766} [modify] https://crrev.com/a88afd250c0e0f76c485358fa8ed621cd20c858f/ash/system/power/peripheral_battery_notifier_unittest.cc
,
Dec 16 2017
PeripheralBatteryNotifierTest.StylusNotification is flaky too. see https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/linux-chromeos-rel/25144
,
Dec 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a6d07a3d475738e07d0453f402df905b6143b97 commit 9a6d07a3d475738e07d0453f402df905b6143b97 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Sat Dec 16 03:42:50 2017 ash: Disable PeripheralBatteryNotifierTest.StylusNotification. Flaky on --mus. TBR=oshima@chromium.org Test: none Bug: 765794 Change-Id: I61cae8ce1b1e016ad1dfb2dd294b043ef548e409 Reviewed-on: https://chromium-review.googlesource.com/831342 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524579} [modify] https://crrev.com/9a6d07a3d475738e07d0453f402df905b6143b97/ash/system/power/peripheral_battery_notifier_unittest.cc
,
Jan 11
Setting defect without priority to Pri-2. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kelv...@chromium.org
, Sep 15 2017