New issue
Advanced search Search tips

Issue 765787 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Sep 21
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

cherry-picking is too hard

Project Member Reported by dcheng@chromium.org, Sep 15 2017

Issue description

I tried creating a cherry-pick on Gerrit, but it didn't auto-cc anyone so I gave up and abandoned it.

Now when I want to use git drover, it tries to reuse that CL (which is abandoned) and fails.


$ git drover --branch 3202 --cherry-pick 4558c28                      
Going to cherry-pick
"""
commit 4558c2885e618557a674660aff57404d25537070
Author: Daniel Cheng <dcheng@chromium.org>
Date:   Fri Sep 8 05:00:29 2017 +0000

    Manually propagate sandbox flags to documents transformed by XSLT

    Normally, this would Just Work but the combination of MHTML and XSLT
    ends up resulting in a weird interaction. MHTML enforces sandbox flags
    on a per-document basis, rather than forcing them on the frame: this
    makes sense, since the sandbox flags enforced by a MHTML document should
    not apply on subsequent pages. However, XSLT installs a new document to
    hold the transformed content. When installing a new Document, the
    effective sandbox flags from the FrameLoader are applied--but MHTML only
    applied them to the Document, so FrameLoader doesn't know about them.
    This fix is to manually propagate the flags for XSLT...

    Bug: 762930
    Change-Id: I29efb0713195febb1ff4e8af7fd27ba1230abab4
    Reviewed-on: https://chromium-review.googlesource.com/656397
    Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    Commit-Queue: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#500510}
"""
to 3202. Continue (y/n)? y
Running presubmit upload checks ...

Presubmit checks passed.
 third_party/WebKit/Source/core/frame/MHTMLTest.cpp         | 24 ++++++++++++++++++++++++
 third_party/WebKit/Source/core/testing/data/mhtml/xslt.mht | 25 +++++++++++++++++++++++++
 third_party/WebKit/Source/core/xml/XSLTProcessor.cpp       |  1 +
 3 files changed, 50 insertions(+)
remote: Processing changes: refs: 1, done
remote: (W) bbe2c21: commit subject >50 characters; use shorter first paragraph
To https://chromium.googlesource.com/chromium/src.git
 ! [remote rejected]           bbe2c21d086cfe1e5683332fb172c118e2c9c453 -> refs/for/refs/branch-heads/3202%ready,notify=ALL,m=Initial_upload (change https://chromium-review.googlesource.com/#/c/chromium/src/+/668804 closed)
error: failed to push some refs to 'https://chromium.googlesource.com/chromium/src.git'
 

Comment 1 by dcheng@chromium.org, Sep 21 2017

Apparently you can just restore abandoned changes (I didn't know that).
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 21

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment