New issue
Advanced search Search tips

Issue 765784 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: ----



Sign in to add a comment

webkit_tests failing on chromium.webkit/WebKit Mac10.9

Project Member Reported by zmin@chromium.org, Sep 15 2017

Issue description

webkit_tests failing on chromium.webkit/WebKit Mac10.9

Builders failed on: 
- WebKit Mac10.9: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9

Failed tests:
fast/text-autosizing/table-inflation-crash.html
virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi.html 

First failure:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/49895

Might be related to:
https://chromium.googlesource.com/chromium/src/+/1882524e81c57ff9ee4061b0473ee30666b560c6

 
Cc: fmalita@chromium.org
Hmm.  Yes, I just did a big-ish rebaseline this morning.

It looks like virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi.html might be flaky?  It seems like the check box is variously selected or not... that's not something changing Skia can affect, but I remember there was some issue of the mouse pointer of the bot interfering with this sort of thing lately.  Ring a bell Florin?

I'm not sure I understand what fast/text-autosizing/table-inflation-crash.html is testing or what the diff is.  A deleted blank line?
Yeah, most likely just flakes we picked up with the rebaseline.

For table-inflation-crash.html we should just revert the CL changes (text only diffs, obviously not related to the rasterization change).

validation-bubble-appearance-hidpi.html looks like it ended up with an extra focus on a control - again most likely unrelated.  Will prolly need to suppress and re-rebaseline.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/733523737d0c22c6b9b32d3e879b888bb6d4fcbf

commit 733523737d0c22c6b9b32d3e879b888bb6d4fcbf
Author: Owen Min <zmin@chromium.org>
Date: Fri Sep 15 21:26:38 2017

Disable two failed tests on WebKit Mac10.9

fast/text-autosizing/table-inflation-crash.html
virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi.html


Bug:  765784 
Change-Id: Ie21c8828e418ab588f9b5f8160f32539817820d7
Tbr: mtklein@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/669310
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502383}
[modify] https://crrev.com/733523737d0c22c6b9b32d3e879b888bb6d4fcbf/third_party/WebKit/LayoutTests/TestExpectations

Oh!  Thank you.  Was just getting geared up to do the same.
Labels: -Sheriff-Chromium
-Sheriff-Chromium as the test is disabled. 
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1eafc9c10e7b7eb5590b3083ec594b99baaea9ae

commit 1eafc9c10e7b7eb5590b3083ec594b99baaea9ae
Author: Florin Malita <fmalita@chromium.org>
Date: Sat Sep 16 18:34:37 2017

Rebaseline two layout tests

Two tests are failing on Mac after
https://chromium-review.googlesource.com/c/chromium/src/+/667219
(rebaseline picked up flake results):

  fast/text-autosizing/table-inflation-crash.html
  virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi.html

BUG= 765784 
TBR=

Change-Id: I02375fe95f92c0d26c960295c74caebd7be4d5dc
Reviewed-on: https://chromium-review.googlesource.com/669843
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502511}
[modify] https://crrev.com/1eafc9c10e7b7eb5590b3083ec594b99baaea9ae/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/ebaed33cb750bd6a891450f955c1ba7804203605/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text-autosizing/table-inflation-crash-expected.txt
[modify] https://crrev.com/1eafc9c10e7b7eb5590b3083ec594b99baaea9ae/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png
[delete] https://crrev.com/ebaed33cb750bd6a891450f955c1ba7804203605/third_party/WebKit/LayoutTests/platform/mac-retina/fast/text-autosizing/table-inflation-crash-expected.txt
[delete] https://crrev.com/ebaed33cb750bd6a891450f955c1ba7804203605/third_party/WebKit/LayoutTests/platform/mac/fast/text-autosizing/table-inflation-crash-expected.txt

Status: Fixed (was: Available)

Sign in to add a comment