New issue
Advanced search Search tips

Issue 765778 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Participants' hotlists:
Downloads-Framework-Service


Sign in to add a comment

Support download error response body.

Project Member Reported by xingliu@chromium.org, Sep 15 2017

Issue description

The fetch api requires download service to fetch the response body for non successful http response code, like 404.


Please see details in:
go/chrome-download-non-successful-server-response
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/748d6b1295e21dd741aefe89b97775f9f2390c19

commit 748d6b1295e21dd741aefe89b97775f9f2390c19
Author: Xing Liu <xingliu@chromium.org>
Date: Thu Sep 28 22:18:09 2017

Support download error response body in content.

This CL adds the logic to download HTTP error response body in content.

Doc: go/chrome-download-non-successful-server-response

Bug:  765778 
Change-Id: I367a9678502de8aace3208776b0dcca51e26c764
Reviewed-on: https://chromium-review.googlesource.com/669300
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505190}
[modify] https://crrev.com/748d6b1295e21dd741aefe89b97775f9f2390c19/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/748d6b1295e21dd741aefe89b97775f9f2390c19/content/browser/download/download_create_info.h
[modify] https://crrev.com/748d6b1295e21dd741aefe89b97775f9f2390c19/content/browser/download/download_item_impl.cc
[modify] https://crrev.com/748d6b1295e21dd741aefe89b97775f9f2390c19/content/browser/download/download_item_impl.h
[modify] https://crrev.com/748d6b1295e21dd741aefe89b97775f9f2390c19/content/browser/download/download_request_core.cc
[modify] https://crrev.com/748d6b1295e21dd741aefe89b97775f9f2390c19/content/browser/download/download_request_core.h
[modify] https://crrev.com/748d6b1295e21dd741aefe89b97775f9f2390c19/content/browser/download/download_response_handler.cc
[modify] https://crrev.com/748d6b1295e21dd741aefe89b97775f9f2390c19/content/browser/download/download_response_handler.h
[modify] https://crrev.com/748d6b1295e21dd741aefe89b97775f9f2390c19/content/browser/download/download_utils.cc
[modify] https://crrev.com/748d6b1295e21dd741aefe89b97775f9f2390c19/content/browser/download/download_utils.h
[modify] https://crrev.com/748d6b1295e21dd741aefe89b97775f9f2390c19/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/748d6b1295e21dd741aefe89b97775f9f2390c19/content/browser/download/resource_downloader.h
[modify] https://crrev.com/748d6b1295e21dd741aefe89b97775f9f2390c19/content/public/browser/download_url_parameters.cc
[modify] https://crrev.com/748d6b1295e21dd741aefe89b97775f9f2390c19/content/public/browser/download_url_parameters.h

Status: Fixed (was: Started)

Sign in to add a comment