The TransientElement manages the visibility for its subtree.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/affa8f07a698002608af8dfd6a532dd97a8128f1 commit affa8f07a698002608af8dfd6a532dd97a8128f1 Author: Yash Malik <ymalik@google.com> Date: Tue Sep 19 18:55:13 2017 [vr] Add GetTarget* getters for all animation types in vr::AnimationPlayer There's a lot of room for duplicate code removal using templates. This is tracked in crbug.com/754820 . Bug: 754822 , 765775 Change-Id: I310ea2414735b13df52c52bd018173b92597a6e4 Reviewed-on: https://chromium-review.googlesource.com/671065 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#502903} [modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/animation_player.cc [modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/animation_player.h [modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/animation_player_unittest.cc [modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/elements/ui_element.h [modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/test/animation_utils.cc [modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/test/animation_utils.h [modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/test/constants.h [modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/ui_scene_manager.cc [modify] https://crrev.com/affa8f07a698002608af8dfd6a532dd97a8128f1/chrome/browser/vr/ui_scene_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa5131c67a1db75f67fa3009529911c322b12a1c commit aa5131c67a1db75f67fa3009529911c322b12a1c Author: Yash Malik <ymalik@google.com> Date: Thu Sep 21 21:47:55 2017 [vr] Replace TransienceManager with TransientElement. This CL introduces TransientElement whose purpose is to hide its portion of the subtree after a set timeout. All the transient elements now have a TransientElement parent and UiSceneManager changes visibility on the parent instead of the child directly. Bug: 765775 Change-Id: I563a72a8d53507bfa91f5fef317ce6ff8ae4f136 Reviewed-on: https://chromium-review.googlesource.com/669009 Commit-Queue: Yash Malik <ymalik@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#503572} [modify] https://crrev.com/aa5131c67a1db75f67fa3009529911c322b12a1c/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/aa5131c67a1db75f67fa3009529911c322b12a1c/chrome/browser/vr/elements/exclusive_screen_toast.cc [modify] https://crrev.com/aa5131c67a1db75f67fa3009529911c322b12a1c/chrome/browser/vr/elements/exclusive_screen_toast.h [modify] https://crrev.com/aa5131c67a1db75f67fa3009529911c322b12a1c/chrome/browser/vr/elements/simple_textured_element.h [delete] https://crrev.com/2a23e10592bac278c1f7bf201e7d0401aa3e9bc3/chrome/browser/vr/elements/transience_manager.cc [delete] https://crrev.com/2a23e10592bac278c1f7bf201e7d0401aa3e9bc3/chrome/browser/vr/elements/transience_manager.h [delete] https://crrev.com/2a23e10592bac278c1f7bf201e7d0401aa3e9bc3/chrome/browser/vr/elements/transience_manager_unittest.cc [add] https://crrev.com/aa5131c67a1db75f67fa3009529911c322b12a1c/chrome/browser/vr/elements/transient_element.cc [add] https://crrev.com/aa5131c67a1db75f67fa3009529911c322b12a1c/chrome/browser/vr/elements/transient_element.h [add] https://crrev.com/aa5131c67a1db75f67fa3009529911c322b12a1c/chrome/browser/vr/elements/transient_element_unittest.cc [modify] https://crrev.com/aa5131c67a1db75f67fa3009529911c322b12a1c/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/aa5131c67a1db75f67fa3009529911c322b12a1c/chrome/browser/vr/elements/ui_element.h [modify] https://crrev.com/aa5131c67a1db75f67fa3009529911c322b12a1c/chrome/browser/vr/elements/ui_element_name.h [modify] https://crrev.com/aa5131c67a1db75f67fa3009529911c322b12a1c/chrome/browser/vr/elements/ui_element_unittest.cc [modify] https://crrev.com/aa5131c67a1db75f67fa3009529911c322b12a1c/chrome/browser/vr/elements/webvr_url_toast.cc [modify] https://crrev.com/aa5131c67a1db75f67fa3009529911c322b12a1c/chrome/browser/vr/elements/webvr_url_toast.h [modify] https://crrev.com/aa5131c67a1db75f67fa3009529911c322b12a1c/chrome/browser/vr/ui_scene.cc [modify] https://crrev.com/aa5131c67a1db75f67fa3009529911c322b12a1c/chrome/browser/vr/ui_scene_manager.cc [modify] https://crrev.com/aa5131c67a1db75f67fa3009529911c322b12a1c/chrome/browser/vr/ui_scene_manager.h [modify] https://crrev.com/aa5131c67a1db75f67fa3009529911c322b12a1c/chrome/browser/vr/ui_scene_manager_unittest.cc [modify] https://crrev.com/aa5131c67a1db75f67fa3009529911c322b12a1c/chrome/browser/vr/ui_scene_unittest.cc
Comment 1 by ymalik@chromium.org
, Sep 15 2017