New issue
Advanced search Search tips

Issue 765773 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Incremental install crashes

Project Member Reported by estevenson@chromium.org, Sep 15 2017

Issue description

Trace looks like:

java.lang.NoClassDefFoundError: org.chromium.build.BuildHooksAndroid
 at org.chromium.incrementalinstall.BootstrapApplication.getResources(BootstrapApplication.java)
 at android.content.ContextWrapper.getResources(ContextWrapper.java:89)
 at android.appwidget.AppWidgetManager.<init>(AppWidgetManager.java:354)
 at android.appwidget.AppWidgetManager.getInstance(AppWidgetManager.java:345)
 at org.chromium.chrome.browser.bookmarkswidget.BookmarkWidgetProvider.onReceive(BookmarkWidgetProvider.java:36)
 at android.app.ActivityThread.handleReceiver(ActivityThread.java:2407)
 at android.app.ActivityThread.access$1700(ActivityThread.java:135)
 at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1272)
 at android.os.Handler.dispatchMessage(Handler.java:102)
 at android.os.Looper.loop(Looper.java:136)
 at android.app.ActivityThread.main(ActivityThread.java:5001)
 at java.lang.reflect.Method.invokeNative(Native Method)
 at java.lang.reflect.Method.invoke(Method.java:515)
 at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
 at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
 at dalvik.system.NativeStart.main(Native Method)

Crashes occur after syncing past https://chromium-review.googlesource.com/c/chromium/src/+/614061.
 
Cc: -estevenson@chromium.org agrieve@chromium.org
Owner: estevenson@chromium.org
I'll take a look at this today
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ea0345a1c60f213e63c1e0efdd4dcee48fd21b1

commit 8ea0345a1c60f213e63c1e0efdd4dcee48fd21b1
Author: Eric Stevenson <estevenson@chromium.org>
Date: Thu Sep 21 19:39:45 2017

Android: Fix incremental install failure on KitKat.

Reference to BootstrapApplication in ActivityThread needed to be
updated to the RealApplication.

Bug:  765773 
Change-Id: I2d26dd691a09bc18b4b409a0d9a3d928609a0671
Reviewed-on: https://chromium-review.googlesource.com/677281
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503535}
[modify] https://crrev.com/8ea0345a1c60f213e63c1e0efdd4dcee48fd21b1/build/android/incremental_install/java/org/chromium/incrementalinstall/BootstrapApplication.java

Status: Fixed (was: Assigned)

Sign in to add a comment