New issue
Advanced search Search tips

Issue 765771 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 580386
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 768565
issue 805325



Sign in to add a comment

Figure out how to recreate contexts after a context loss (GPU crash) in WebMediaPlayerImpl

Project Member Reported by piman@chromium.org, Sep 15 2017

Issue description

https://chromium-review.googlesource.com/c/chromium/src/+/668029/1 made that clearer, but even before that patch, the Context3DCB callback, used to get a context for WebMediaPlayerImpl::Paint and WebMediaPlayerImpl::CopyVideoTextureToPlatformTexture, binds the context at callback creation time (see https://cs.chromium.org/chromium/src/content/renderer/media/media_factory.cc?q=content/renderer/media/media_factory.cc&sq=package:chromium&l=211), not when the callback is called. This means the context is constant for the duration of WMPI, but it needs to be recreated after a GPU crash (which puts the context into "lost" state and it becomes non-functional), see https://cs.chromium.org/chromium/src/content/renderer/render_thread_impl.cc?type=cs&q=RenderThreadImpl::SharedMainThreadContextProvider&sq=package:chromium&l=1485
 
Cc: dcasta...@chromium.org liber...@chromium.org
+dcastagna since I can't quite remember where we left off on this for GpuVideoDecoder and VideoFrame GpuMemoryBuffers. 
Status: Assigned (was: Untriaged)
Blocking: 768565
Cc: lethalantidote@chromium.org
Owner: ----
Status: Available (was: Assigned)
I don't have the bandwidth to take this on atm, so I'll demote myself to CC.
Cc: mcasas@chromium.org
Blocking: 805325
Components: Internals>GPU>Video
cc dcastagna@ since we were talking about this today.
Mergedinto: 580386
Status: Duplicate (was: Available)

Sign in to add a comment