New issue
Advanced search Search tips

Issue 765754 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Update Fuchsia from Magenta to Zircon

Project Member Reported by scottmg@chromium.org, Sep 15 2017

Issue description

Fuchsia changed the kernel name from Magenta to Zircon, along with the associated function names mx_ -> zx_, MX_ to ZX_, etc.

https://fuchsia.googlesource.com/scripts/+/master/zirconize.sh

src.git is mostly trivial, but third_party might take some 3-sided rolls. (v8 and boringssl in particular)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://boringssl.googlesource.com/boringssl/+/f51f273ee8eb67e1b2b36bb9ef576bd8ff8632bc

commit f51f273ee8eb67e1b2b36bb9ef576bd8ff8632bc
Author: David Benjamin <davidben@google.com>
Date: Fri Sep 15 19:13:35 2017

Temporarily gate new Fuchsia APIs on CHROMIUM_ROLLING_MAGENTA_TO_ZIRCON.

This is to keep Chromium building.

Bug:  chromium:765754 
Change-Id: I312f747e27e53590a948305f80abc240bfd2063c
Reviewed-on: https://boringssl-review.googlesource.com/20344
Reviewed-by: Aaron Green <aarongreen@google.com>
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>

[modify] https://crrev.com/f51f273ee8eb67e1b2b36bb9ef576bd8ff8632bc/crypto/rand_extra/fuchsia.c

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/aabb893a3259c72a78920771280d0832411c92c1

commit aabb893a3259c72a78920771280d0832411c92c1
Author: Scott Graham <scottmg@chromium.org>
Date: Fri Sep 15 19:23:39 2017

fuchsia: Set up for 3-sided roll to convert Magenta->Zircon

Fuchsia changed their kernel name from Magenta to Zircon and all the
functions and defines along with it. In order to be able to roll the SDK
in Chromium, we first need to land with this define added in v8, so that
can roll in to Chromium, then roll the Fuchsia SDK with this magic
define set (CHROMIUM_ROLLING_MAGENTA_TO_ZIRCON), then actually update v8
to reference zx_ instead of mx_ and roll that again.

Chromium-side for reference: https://chromium-review.googlesource.com/c/chromium/src/+/669139

Bug:  chromium:765754 , chromium:707030
Change-Id: I4ed5027f455d2346f431e7c700e87693348d5b79
Reviewed-on: https://chromium-review.googlesource.com/668751
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48047}
[modify] https://crrev.com/aabb893a3259c72a78920771280d0832411c92c1/src/base/platform/platform-fuchsia.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/8c89502008d6475b558beaf53324b5a852bba8dc

commit 8c89502008d6475b558beaf53324b5a852bba8dc
Author: Michael Hablich <hablich@chromium.org>
Date: Mon Sep 18 07:58:14 2017

Revert "fuchsia: Set up for 3-sided roll to convert Magenta->Zircon"

This reverts commit aabb893a3259c72a78920771280d0832411c92c1.

Reason for revert: blocks roll https://chromium-review.googlesource.com/c/chromium/src/+/669540; Fix has not landed yet: https://chromium-review.googlesource.com/c/v8/v8/+/670280

Original change's description:
> fuchsia: Set up for 3-sided roll to convert Magenta->Zircon
> 
> Fuchsia changed their kernel name from Magenta to Zircon and all the
> functions and defines along with it. In order to be able to roll the SDK
> in Chromium, we first need to land with this define added in v8, so that
> can roll in to Chromium, then roll the Fuchsia SDK with this magic
> define set (CHROMIUM_ROLLING_MAGENTA_TO_ZIRCON), then actually update v8
> to reference zx_ instead of mx_ and roll that again.
> 
> Chromium-side for reference: https://chromium-review.googlesource.com/c/chromium/src/+/669139
> 
> Bug:  chromium:765754 , chromium:707030
> Change-Id: I4ed5027f455d2346f431e7c700e87693348d5b79
> Reviewed-on: https://chromium-review.googlesource.com/668751
> Reviewed-by: Bill Budge <bbudge@chromium.org>
> Commit-Queue: Scott Graham <scottmg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#48047}

TBR=bbudge@chromium.org,scottmg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:765754 , chromium:707030
Change-Id: Ic1563b10a69372a0946ee9eacc8a2d21eb3ee302
Reviewed-on: https://chromium-review.googlesource.com/670619
Reviewed-by: Michael Hablich <hablich@chromium.org>
Commit-Queue: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48059}
[modify] https://crrev.com/8c89502008d6475b558beaf53324b5a852bba8dc/src/base/platform/platform-fuchsia.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/afbdd1dd49045daa50245181d7cf55167e1ef198

commit afbdd1dd49045daa50245181d7cf55167e1ef198
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Sep 18 15:00:47 2017

Reland "fuchsia: Set up for 3-sided roll to convert Magenta->Zircon"

This is a reland of aabb893a3259c72a78920771280d0832411c92c1
Original change's description:
> fuchsia: Set up for 3-sided roll to convert Magenta->Zircon
> 
> Fuchsia changed their kernel name from Magenta to Zircon and all the
> functions and defines along with it. In order to be able to roll the SDK
> in Chromium, we first need to land with this define added in v8, so that
> can roll in to Chromium, then roll the Fuchsia SDK with this magic
> define set (CHROMIUM_ROLLING_MAGENTA_TO_ZIRCON), then actually update v8
> to reference zx_ instead of mx_ and roll that again.
> 
> Chromium-side for reference: https://chromium-review.googlesource.com/c/chromium/src/+/669139
> 
> Bug:  chromium:765754 , chromium:707030
> Change-Id: I4ed5027f455d2346f431e7c700e87693348d5b79
> Reviewed-on: https://chromium-review.googlesource.com/668751
> Reviewed-by: Bill Budge <bbudge@chromium.org>
> Commit-Queue: Scott Graham <scottmg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#48047}

TBR=bbudge@chromium.org

Bug:  chromium:765754 , chromium:707030
Change-Id: Ib6e99ca418af527014622614d07d295b6110f9d5
Reviewed-on: https://chromium-review.googlesource.com/670944
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48067}
[modify] https://crrev.com/afbdd1dd49045daa50245181d7cf55167e1ef198/src/base/platform/platform-fuchsia.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe0e9f46ab247ff5a28a823f344c93230953018f

commit fe0e9f46ab247ff5a28a823f344c93230953018f
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Sep 18 21:25:04 2017

fuchsia: Magenta -> Zircon

Includes a Fuchsia SDK update, and a lot of mx_ -> zx_, et al.

Sets CHROMIUM_ROLLING_MAGENTA_TO_ZIRCON=1 as a global define
temporarily to support for 3-sided rolls of third_party DEPS.

Requires https://chromium-review.googlesource.com/c/v8/v8/+/668751 to
have landed and rolled.

Requires boringssl roll with similar change to have landed
https://chromium-review.googlesource.com/c/chromium/src/+/668704.

R=dcheng@chromium.org,nick@chromium.org,tsepez@chromium.org,rockot@chromium.org
TBR=nick@chromium.org

Bug:  765754 , 707030
Change-Id: I6c2ad37b3c5b13c2a3a98da6e1ff9160ad2de949
Reviewed-on: https://chromium-review.googlesource.com/669139
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502678}
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/DEPS
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/BUILD.gn
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/debug/stack_trace_fuchsia.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/fuchsia/default_job.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/fuchsia/default_job.h
[delete] https://crrev.com/f9c2ab69a068a6c9b589086b7c9d1331a166dc1e/base/fuchsia/scoped_mx_handle.h
[add] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/fuchsia/scoped_zx_handle.h
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/memory/shared_memory_fuchsia.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/memory/shared_memory_handle.h
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/memory/shared_memory_handle_fuchsia.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/memory/shared_memory_unittest.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/message_loop/message_loop.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/message_loop/message_loop.h
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/message_loop/message_pump_fuchsia.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/message_loop/message_pump_fuchsia.h
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/metrics/field_trial.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/process/kill_fuchsia.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/process/launch.h
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/process/launch_fuchsia.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/process/process.h
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/process/process_fuchsia.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/process/process_handle.h
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/process/process_handle_fuchsia.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/process/process_util_unittest.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/rand_util_fuchsia.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/sys_info_fuchsia.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/test/launcher/test_launcher.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/threading/platform_thread.h
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/threading/platform_thread_posix.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/time/time.h
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/time/time_fuchsia.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/base/trace_event/heap_profiler_allocation_register_posix.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/build/config/fuchsia/BUILD.gn
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/build/fuchsia/runner_common.py
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/content/browser/browser_main_loop.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/content/browser/tracing/tracing_controller_impl.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/ipc/handle_attachment_fuchsia.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/ipc/handle_attachment_fuchsia.h
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/ipc/handle_fuchsia.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/ipc/handle_fuchsia.h
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/ipc/ipc_message_attachment.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/mojo/edk/embedder/platform_channel_pair_fuchsia.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/mojo/edk/embedder/platform_handle.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/mojo/edk/embedder/platform_handle.h
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/mojo/edk/embedder/platform_handle_utils_fuchsia.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/mojo/edk/system/channel.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/mojo/edk/system/channel.h
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/mojo/edk/system/channel_fuchsia.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/mojo/edk/system/platform_wrapper_unittest.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/mojo/public/c/system/platform_handle.h
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/mojo/public/cpp/system/platform_handle.cc
[modify] https://crrev.com/fe0e9f46ab247ff5a28a823f344c93230953018f/net/base/net_errors_posix.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 18 2017

The following revision refers to this bug:
  https://boringssl.googlesource.com/boringssl/+/1d6e36525d5010c4478ad3f96da9ec0274ddef88

commit 1d6e36525d5010c4478ad3f96da9ec0274ddef88
Author: David Benjamin <davidben@google.com>
Date: Mon Sep 18 21:34:32 2017

Remove CHROMIUM_ROLLING_MAGENTA_TO_ZIRCON scaffolding.

https://chromium-review.googlesource.com/c/chromium/src/+/669139 has
landed.

Bug:  chromium:765754 
Change-Id: I6f6c52f053698348673eaa1e2574801b3f6b2041
Reviewed-on: https://boringssl-review.googlesource.com/20505
Reviewed-by: Steven Valdez <svaldez@google.com>
Commit-Queue: Steven Valdez <svaldez@google.com>
CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>

[modify] https://crrev.com/1d6e36525d5010c4478ad3f96da9ec0274ddef88/crypto/rand_extra/fuchsia.c

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a900e53f044ee3634de1adb2dd418d0c7d18401b

commit a900e53f044ee3634de1adb2dd418d0c7d18401b
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Sep 18 22:37:53 2017

fuchsia: Remove scaffolding for 3-sided roll

Chromium has rolled the Fuchsia SDK, so this can be removed now, and
the new zx_, etc. names used exclusively.

Bug:  chromium:765754 
Change-Id: I8bd60239da7a05e62d3b8d5209e1cfe898d8052a
Reviewed-on: https://chromium-review.googlesource.com/671769
Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48071}
[modify] https://crrev.com/a900e53f044ee3634de1adb2dd418d0c7d18401b/src/base/platform/platform-fuchsia.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a19fc90d228b91492f55828b26b259629b4778d1

commit a19fc90d228b91492f55828b26b259629b4778d1
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Mon Sep 18 23:51:52 2017

magenta->zircon in tools/fuchsia/local-sdk.py

Updated local-sdk.py to call build-zircon.sh instead of
build-magenta.sh .

Change-Id: I2ae2000edf9c4c487ae2b4b8ece61764f1a2ba51
Bug:  765754 
Reviewed-on: https://chromium-review.googlesource.com/671536
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502717}
[modify] https://crrev.com/a19fc90d228b91492f55828b26b259629b4778d1/tools/fuchsia/local-sdk.py

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e0dadef1db44ca63c3709ebb6eefb82de9a310c

commit 6e0dadef1db44ca63c3709ebb6eefb82de9a310c
Author: Scott Graham <scottmg@chromium.org>
Date: Mon Oct 09 19:28:24 2017

fuchsia: Tidy up flags used for 3-sided rolls for Magenta->Zircon

Bug:  765754 
Change-Id: Ia3ccabe10d902931c804e1f01c32afccd38b5e04
Reviewed-on: https://chromium-review.googlesource.com/671213
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507445}
[modify] https://crrev.com/6e0dadef1db44ca63c3709ebb6eefb82de9a310c/build/config/fuchsia/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment