New issue
Advanced search Search tips

Issue 765733 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

ExternalProtocolHandlerTest.TestLaunchSchemeUnknownChromeUnknown failed on Android Tests

Project Member Reported by kelv...@chromium.org, Sep 15 2017

Issue description

Target Builder: 
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests

First build failed:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/45916

Failure log:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid_Tests%2F45916%2F%2B%2Frecipes%2Fsteps%2Funit_tests_on_Android%2F0%2Flogs%2FExternalProtocolHandlerTest.TestLaunchSchemeUnknownChromeUnknown%2F0

[ RUN      ] FamilyInfoFetcherTest.FailedResponse
[       OK ] FamilyInfoFetcherTest.FailedResponse (0 ms)
[----------] 7 tests from FamilyInfoFetcherTest (3 ms total)
[----------] Global test environment tear-down
[==========] 94 tests from 14 test cases ran. (818 ms total)
[  PASSED  ] 90 tests.
[  FAILED  ] 4 tests, listed below:
[  FAILED  ] ExternalProtocolHandlerTest.TestLaunchSchemeUnBlockedChromeOtherModeDefault
[  FAILED  ] ExternalProtocolHandlerTest.TestLaunchSchemeUnknownChromeNotDefault
[  FAILED  ] ExternalProtocolHandlerTest.TestLaunchSchemeUnknownChromeUnknown
[ RUN      ] ExternalProtocolHandlerTest.TestLaunchSchemeUnknownChromeOtherModeDefault
../../chrome/browser/external_protocol/external_protocol_handler_unittest.cc:146: Failure
      Expected: expected_action == Action::PROMPT
      Which is: true
To be equal to: delegate_.has_prompted()
      Which is: false
[  FAILED  ] ExternalProtocolHandlerTest.TestLaunchSchemeUnknownChromeOtherModeDefault (8 ms)
[----------] 4 tests from ExternalProtocolHandlerTest (57 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 1 test case ran. (59 ms total)
[  PASSED  ] 1 test.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] ExternalProtocolHandlerTest.TestLaunchSchemeUnknownChromeNotDefault
[  FAILED  ] ExternalProtocolHandlerTest.TestLaunchSchemeUnknownChromeUnknown
[ RUN      ] ExternalProtocolHandlerTest.TestLaunchSchemeUnknownChromeUnknown
[ CRASHED      ]

 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db89c2a839aa591ed52093c71d6a05893c50765d

commit db89c2a839aa591ed52093c71d6a05893c50765d
Author: kelvinp@chromium.org <kelvinp@chromium.org>
Date: Fri Sep 15 21:17:24 2017

Disable flakey ExternalProtocolHandlerTest.TestLaunchSchemeUnknownChromeUnknown

TBR=benwells
NOTRY=true

Bug:  765733 
Change-Id: If72b82bf0231f1fae8517a699b394691a913adc2
Reviewed-on: https://chromium-review.googlesource.com/668691
Commit-Queue: Kelvin Poon <kelvinp@chromium.org>
Reviewed-by: Kelvin Poon <kelvinp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502379}
[modify] https://crrev.com/db89c2a839aa591ed52093c71d6a05893c50765d/chrome/browser/external_protocol/external_protocol_handler_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f54b3ba0144424fc95f4615bede99d01dcfb80e2

commit f54b3ba0144424fc95f4615bede99d01dcfb80e2
Author: Ben Wells <benwells@chromium.org>
Date: Wed Oct 11 05:07:28 2017

Fix flaky external protocol handler tests.

The tests failed when multiple DefaultWebClientWorker tests were run by
the same process.

Bug:  765733 
Change-Id: I9567c780aa2a2fef1d87ab13fde2773837790ad3
Reviewed-on: https://chromium-review.googlesource.com/674891
Commit-Queue: Ben Wells <benwells@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507898}
[modify] https://crrev.com/f54b3ba0144424fc95f4615bede99d01dcfb80e2/chrome/browser/external_protocol/external_protocol_handler_unittest.cc
[modify] https://crrev.com/f54b3ba0144424fc95f4615bede99d01dcfb80e2/chrome/browser/shell_integration.cc
[modify] https://crrev.com/f54b3ba0144424fc95f4615bede99d01dcfb80e2/chrome/browser/shell_integration.h

Status: Fixed (was: Assigned)

Comment 4 by gab@chromium.org, Apr 12 2018

Cc: fdoray@chromium.org pmonette@chromium.org
 Issue 765475  has been merged into this issue.

Sign in to add a comment