Replace model list implementation in cros-unibuild.eclass |
|||
Issue descriptioncros-unibuild.eclass has a function called: get_model_list At present it calls fdtget. We should update it to use cros_config_host now. You can check it works correctly with a coral build (./build_packages --board=coral to start) emerge-coral chromeos-firmware-coral Once the stdin support is done, you can update get_model_list_noroot as well. Same test procedure.
,
Sep 15 2017
Yes, we will need that. It might be necessary to split out a new ebuild too?
,
Sep 15 2017
I don't think so: the discussion about using cros_host USE flag should be sufficient. We just need to add it to the SDK build target and then wait a weeks or two for an SDK uprev to propagate out to folks. Alec, Ben (bmgordon@) has the most experience with doing this in our work group. We might ask him for the steps.
,
Sep 15 2017
Hoping that adding the dependency is enough, at least to get builds passing.
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/398b4592c8ccbbedc47b947b40cec192d1592afb commit 398b4592c8ccbbedc47b947b40cec192d1592afb Author: Alec Thilenius <athilenius@chromium.org> Date: Fri Sep 22 00:19:52 2017 Add chromeos-base/chromeos-config-tools ebuild Added cros_config as a basic utility to ebuild. cros_config and cros_config_host can be used to get model information from the dtb config database. BUG= chromium:765697 TEST=Locally build_packages and checked cros_config_host installed Change-Id: I2718d94974336636829e5a1d4b8c05bace49f8ae Reviewed-on: https://chromium-review.googlesource.com/675568 Commit-Ready: Alec Thilenius <athilenius@chromium.org> Tested-by: Alec Thilenius <athilenius@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/398b4592c8ccbbedc47b947b40cec192d1592afb/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1.ebuild [rename] https://crrev.com/398b4592c8ccbbedc47b947b40cec192d1592afb/virtual/target-chromium-os-sdk/target-chromium-os-sdk-1-r84.ebuild
,
Sep 22 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jclinton@chromium.org
, Sep 15 2017