New issue
Advanced search Search tips

Issue 765696 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Shelf icon "running" dots are missing on high dpi devices

Project Member Reported by jamescook@chromium.org, Sep 15 2017

Issue description

Chrome ToT r502260 on device (link) and on linux desktop (scale factor 2)

Running chrome at normal DPI shows white dots under the shelf icons for running browsers/apps.

Running in high DPI shows nothing, e.g. --ash-host-window-bounds="2000x1000*2"

Did something break with the art assets?

oshima, can you triage?

 
Screenshot from 2017-09-15 09:57:51.png
92.3 KB View Download
Screenshot from 2017-09-15 09:58:06.png
71.7 KB View Download
Here's normal DPI at the same revision.

Screenshot from 2017-09-15 10:01:36.png
18.0 KB View Download

Comment 2 by osh...@chromium.org, Sep 15 2017

Owner: malaykeshav@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e66c7480df26431d7fb20fd2d206c0f973884dc

commit 6e66c7480df26431d7fb20fd2d206c0f973884dc
Author: F#m <malaykeshav@chromium.org>
Date: Wed Sep 20 01:22:35 2017

Applies recording scale factor during solid color analysis

During solid color analysis for RecordingSource, the analysis rect needs
to be scaled by the recording scale factor.

Bug:  765696 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I996e099aa2d5062d165d1d4714b826b312b84e9a
COMPONENT: Chrome OS, Recording Source, Solid Color Analysis
Reviewed-on: https://chromium-review.googlesource.com/672123
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503017}
[modify] https://crrev.com/6e66c7480df26431d7fb20fd2d206c0f973884dc/cc/layers/recording_source.cc
[modify] https://crrev.com/6e66c7480df26431d7fb20fd2d206c0f973884dc/cc/layers/recording_source_unittest.cc

Status: Fixed (was: Started)
Issue 766192 has been merged into this issue.

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 8 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment