New issue
Advanced search Search tips

Issue 765692 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 765852



Sign in to add a comment

ClangToT bots failing with static_assert

Project Member Reported by h...@chromium.org, Sep 15 2017

Issue description

From https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/9093:


../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/base/base_nocompile_tests/bind_unittest_nc.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"313357\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DGTEST_API_= -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=1 -DUNIT_TEST -I../.. -Igen -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_jessie_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/googletest/src/googletest/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -O2 -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g2 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=gnu++14 -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_jessie_amd64-sysroot -fno-exceptions -fvisibility-inlines-hidden -c gen/base/bind_unittest_nc.cc -o obj/base/base_nocompile_tests/bind_unittest_nc.o
gen/base/bind_unittest_nc.cc:18:2: error: "NCTEST_CONST_POINTER Failed: Expectations [r'fatal error: static_assert failed \"Bound argument \|i\| of type \|Arg\| cannot be forwarded as \|Unwrapped\| to the bound functor, which declares it as \|Param\|\.\"'] did not match output."
#error "NCTEST_CONST_POINTER Failed: Expectations [r'fatal error: static_assert failed \"Bound argument \|i\| of type \|Arg\| cannot be forwarded as \|Unwrapped\| to the bound functor, which declares it as \|Param\|\.\"'] did not match output."
 ^
 

Comment 1 by h...@chromium.org, Sep 15 2017

Build 9092 (which seems to have failed for other reasons) was at Clang r313352
Build 9093 used clang r313357


Nothing in that range looks suspicious:

------------------------------------------------------------------------
r313352 | ibiryukov | 2017-09-15 03:15:00 -0700 (Fri, 15 Sep 2017) | 5 lines

Revert "[SLPVectorizer] Failure to beneficially vectorize 'copyable' elements in integer binary ops."

This reverts commit r313348.

Reason: it caused buildbot failures.
------------------------------------------------------------------------
r313353 | rksimon | 2017-09-15 04:17:42 -0700 (Fri, 15 Sep 2017) | 3 lines

[X86][SSE] Add test cases vector for integer multiplies

Mainly inspired by PR34474 / D37896
------------------------------------------------------------------------
r313354 | krasimir | 2017-09-15 04:23:50 -0700 (Fri, 15 Sep 2017) | 22 lines

[clang-format] New flag - BraceWrapping.AfterExternBlock

Summary:
Bug: https://bugs.llvm.org/show_bug.cgi?id=34016 - **"extern C part"**

**Problem:**

Due to the lack of "brace wrapping extern" flag, clang format does parse the block after **extern** keyword moving the opening bracket to the header line always!

**Patch description:**

A new style added, new configuration flag - **BraceWrapping.AfterExternBlock** that allows us to decide whether we want a break before brace or not.

Reviewers: djasper, krasimir

Reviewed By: krasimir

Subscribers: klimek, cfe-commits

Differential Revision: https://reviews.llvm.org/D37845

Contributed by @PriMee!
------------------------------------------------------------------------
r313355 | alexfh | 2017-09-15 04:28:28 -0700 (Fri, 15 Sep 2017) | 24 lines

[clang-tidy] Fixed misc-unused-parameters omitting parameters square brackets

Summary:
Bug: https://bugs.llvm.org/show_bug.cgi?id=34449

**Problem:**

Clang-tidy check misc-unused-parameters comments out parameter name omitting following characters (e.g. square brackets) what results in its complete removal. Compilation errors might occur after clang-tidy fix as well.

**Patch description:**

Changed removal range. The range should end after parameter name, not after whole parameter declarator (which might be followed by e.g. square brackets).

Reviewers: alexfh

Reviewed By: alexfh

Subscribers: JDevlieghere, xazax.hun, cfe-commits

Tags: #clang-tools-extra

Patch by Pawel Maciocha!

Differential Revision: https://reviews.llvm.org/D37846
------------------------------------------------------------------------
r313356 | alexfh | 2017-09-15 04:45:30 -0700 (Fri, 15 Sep 2017) | 3 lines

Add a ReleaseNotes blurb for Execute.*Wait API change

... in r313155, r313156.
------------------------------------------------------------------------
r313357 | alexfh | 2017-09-15 04:45:57 -0700 (Fri, 15 Sep 2017) | 1 line

Remove unneeded forward declaration. NFC
------------------------------------------------------------------------

Comment 2 by r...@chromium.org, Sep 15 2017

r313315 looks related, and the blame range is larger because 9092 failed for other reasons, right?

Comment 3 by dcheng@chromium.org, Sep 15 2017

I think the nocompile expectations just need to be updated. The error is now:
fatal error: static_assert failed due to requirement 'param_is_forwardable' "..."

But the nocompile expectation is looking for:
fatal error: static_assert failed "..."

Comment 4 by h...@chromium.org, Sep 15 2017

> r313315 looks related, and the blame range is larger because 9092 failed for other reasons, right?

Ah, yes.

For some reason, this doesn't repro locally for me. I must be holding it wrong somehow..

Comment 5 by h...@chromium.org, Sep 15 2017

Aha, the nocompile tests don't respect clang_base_path:
https://cs.chromium.org/chromium/src/tools/nocompile_driver.py?rcl=07a8b4129c235bf171061472ca683a662fd9b316&l=214

  # TODO(ajwong): Get the compiler from gyp.
  cmdline = [os.path.join(os.path.dirname(os.path.realpath(__file__)),
                          '../third_party/llvm-build/Release+Asserts/bin',
                          'clang++')]

Comment 6 by h...@chromium.org, Sep 15 2017

Status: Started (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8023548f9723803b7b2dfdcb0cc2020011ea7867

commit 8023548f9723803b7b2dfdcb0cc2020011ea7867
Author: Hans Wennborg <hans@chromium.org>
Date: Fri Sep 15 18:34:51 2017

Fix base_nocompile_tests after Clang's static_assert wording changed

After Clang r313315, the static_assert errors look like:

  fatal error: static_assert failed due to requirement
  'param_is_forwardable' "Bound argument |i| of type |Arg| cannot be
  forwarded as [..]

instead of the previously expected:

  fatal error: static_assert failed "Bound argument |i| of type
  |Arg| cannot be forwarded as [..]

Since the test needs to work with both tip-of-tree and the currently
pinned version of Clang, add a regex to the expectations to make them
match both cases.

TBR=dcheng

Bug:  765692 
Change-Id: I6271fcdb8f346ffd359dd98f4bfcb32f5fdc9480
Reviewed-on: https://chromium-review.googlesource.com/668572
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502315}
[modify] https://crrev.com/8023548f9723803b7b2dfdcb0cc2020011ea7867/base/bind_unittest.nc
[modify] https://crrev.com/8023548f9723803b7b2dfdcb0cc2020011ea7867/base/memory/ref_counted_unittest.nc
[modify] https://crrev.com/8023548f9723803b7b2dfdcb0cc2020011ea7867/base/memory/weak_ptr_unittest.nc

Comment 9 by h...@chromium.org, Sep 15 2017

Status: Fixed (was: Started)

Comment 10 by h...@chromium.org, Sep 20 2017

Blocking: 765852

Sign in to add a comment