New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 765679 link

Starred by 1 user
Status: Fixed
Owner:
bpastene@chromium.org
Closed: Sep 2017
Cc:
█ yolandyan@chromium.org
kjlubick@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 763951



Sign in to add a comment

Fix py-adb for O

Project Member Reported by bpastene@chromium.org, Sep 15 2017 
Looks like its borked: "Android O seems to be making /system/build.prop read-only for root."

Work around might be to collect the build props via getprop instead of reading that file.

Comment 1 by bpastene@chromium.org, Sep 15 2017

Components: -Infra>Client Infra>Client>Chrome

Comment 2 by bpastene@chromium.org, Sep 16 2017

Cc: yolandyan@chromium.org
Flashed an N5X to OPR4.170623.006 and it looks to be running into the same issue:
https://chromium-swarm.appspot.com/bot?id=build251-m4--device1

I see "open failed: Permission denied" show up in the logs when it tries to read /system/build.prop. I'll try to get to a fix sometime next week.

Comment 3 by bpastene@chromium.org, Sep 16 2017

Blocking: 763951
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/python-adb/+/34bfe6be0ca540a86302fa0493d85b034ca97402

commit 34bfe6be0ca540a86302fa0493d85b034ca97402
Author: Benjamin Pastene <bpastene@chromium.org>
Date: Tue Sep 19 00:58:54 2017

python-adb: Fallback to getprop when /system/build.prop is not readable.

Bug:  765679 
Change-Id: Ib5e65ea798231b0d99679322f37c98d0b0f32778
Reviewed-on: https://chromium-review.googlesource.com/671933
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/34bfe6be0ca540a86302fa0493d85b034ca97402/adb/contrib/high.py
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/aaa2efb7d2c83a2860a29357f13a998323789784

commit aaa2efb7d2c83a2860a29357f13a998323789784
Author: Benjamin Pastene <bpastene@chromium.org>
Date: Tue Sep 19 19:19:47 2017

swarming: Roll py-adb to 34bfe6b

TBR=maruel@chromium.org
Bug:  765679 
Change-Id: I0646ed99c6c3ea7684c8283ae286975408d8dad3
Reviewed-on: https://chromium-review.googlesource.com/673129
Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>

[modify] https://crrev.com/aaa2efb7d2c83a2860a29357f13a998323789784/appengine/third_party/python-adb/README.swarming
[modify] https://crrev.com/aaa2efb7d2c83a2860a29357f13a998323789784/appengine/third_party/python-adb/adb/contrib/high.py

Comment 6 by bpastene@chromium.org, Sep 19 2017

Status: Fixed (was: Assigned)
This should be fixed.
►

Sign in to add a comment