New issue
Advanced search Search tips

Issue 765645 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Feature


Participants' hotlists:
Harmony-Ready-For-Review


Sign in to add a comment

ScrollView overflow indicator bars

Project Member Reported by kylixrd@chromium.org, Sep 15 2017

Issue description

OS: Win, Linux, Chrome

Material Design mode.

Certain scrollable views should display an "overflow" indicator bar on the view's edge which has content in the implied direction beyond the visible region.

See images.

Second image is an example mock demonstrating where the overflow indicator bar should appear.

From meeting with UX team: Overflow indicator bar will match the width of the scrollable view, not the full width of the dialog.


 
ScrollViewOverFlowBars.png
11.5 KB View Download
OverflowIndicators.png
13.6 KB View Download
Cc: bettes@chromium.org
Description: Show this description
Cc: kylixrd@chromium.org
 Issue 765646  has been merged into this issue.
This is now how the dialog looks with the overflow indicators on the scroll view.
PopupDialogWithOverflowIndicators.png
11.4 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26971b3432f8d8352f73cbddf376691762718bc3

commit 26971b3432f8d8352f73cbddf376691762718bc3
Author: Allen Bauer <kylixrd@chromium.org>
Date: Mon Sep 25 17:55:53 2017

Add ScrollView support for showing overflow indicator bars on the edge of the viewport which has more content in that direction.

Use SetShowEdgesWithHiddenContent() to enable/disable this feature.

Bug:  765645 
Change-Id: Ic8a1ffab3d15ca703d5dd010b44286ca3ad854fb
Reviewed-on: https://chromium-review.googlesource.com/671501
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504100}
[modify] https://crrev.com/26971b3432f8d8352f73cbddf376691762718bc3/ui/views/controls/scroll_view.cc
[modify] https://crrev.com/26971b3432f8d8352f73cbddf376691762718bc3/ui/views/controls/scroll_view.h
[modify] https://crrev.com/26971b3432f8d8352f73cbddf376691762718bc3/ui/views/controls/scroll_view_unittest.cc

Comment 6 by bettes@chromium.org, Oct 10 2017

Are there instructions on how to trigger a scrollview on popups?
Navigate to: http://www.popuptest.com/popuptest1.html.

That will attempt to open 10 popups, which should all be blocked and listed in the blocked popups dialog.
Owner: bettes@chromium.org
re-assigning this to bettes for review as instructions are provided in #7.

Comment 9 by bettes@chromium.org, Oct 30 2017

This bug is specifically about scrollview overflow bars so this LGTM and can be marked as Fixed. 


Status: Fixed (was: Assigned)

Sign in to add a comment