New issue
Advanced search Search tips

Issue 765619 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

19.6% regression in blink_perf.paint at 501337:501425

Project Member Reported by toyoshim@chromium.org, Sep 15 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Sep 15 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=765619

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=91669cdd0dd778837831a1a4455df2b7a2011b2e4856aff1376344a8f9fc79cd


Bot(s) for this bug's original alert(s):

android-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Sep 15 2017

Cc: wangxianzhu@chromium.org
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author wangxianzhu@chromium.org ===

Hi wangxianzhu@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Xianzhu Wang
  Commit : 50e9e5ac22f5c1bfb26a1d0e2c84126cf8f0df81
  Date   : Tue Sep 12 20:09:31 2017
  Subject: Move LocationInBacking and SelectionVisualRect from into RarePaintData

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : blink_perf.paint
  Metric       : large-table-background-change-with-invisible-collapsed-borders/large-table-background-change-with-invisible-collapsed-borders
  Change       : 13.90% | 635.712166667 -> 724.05725

Revision             Result                  N
chromium@501336      635.712 +- 9.31664      6      good
chromium@501358      641.781 +- 51.6716      6      good
chromium@501369      634.134 +- 12.2545      6      good
chromium@501374      643.833 +- 19.9256      6      good
chromium@501375      722.613 +- 24.6698      6      bad       <--
chromium@501376      717.867 +- 6.56028      6      bad
chromium@501377      718.083 +- 12.6435      6      bad
chromium@501379      711.951 +- 19.1943      6      bad
chromium@501425      724.057 +- 13.1194      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.paint

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8968386704905155120


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Sep 26 2017

 Issue 768677  has been merged into this issue.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Sep 26 2017

 Issue 768677  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bf022ea5f59ac51c7705b0f8235b43fbb8dc58c

commit 5bf022ea5f59ac51c7705b0f8235b43fbb8dc58c
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Sep 28 03:45:47 2017

Don't always allocate RarePaintData for selection visual rect

Bug:  765619 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0a9beaf064389dd136b63b8a24810864a4d008d7
Reviewed-on: https://chromium-review.googlesource.com/687868
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504888}
[modify] https://crrev.com/5bf022ea5f59ac51c7705b0f8235b43fbb8dc58c/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/5bf022ea5f59ac51c7705b0f8235b43fbb8dc58c/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/5bf022ea5f59ac51c7705b0f8235b43fbb8dc58c/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp
[modify] https://crrev.com/5bf022ea5f59ac51c7705b0f8235b43fbb8dc58c/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp

Components: Blink>Paint
Status: Fixed (was: Assigned)

Sign in to add a comment