Regressionn: Browser doesn't navigate to chrome://interstitials/ after clicking on back navigation button
Reported by
nutan.ga...@etouch.net,
Sep 15 2017
|
||||||||||
Issue descriptionChrome Version:63.0.3216.0 (Official Build) c3592928ad6753206a00d98787a578cda6153570-refs/heads/master@{#502108}(64-bit) OS: Windows (7,8,10), Linux(14.04), Mac(10.11.6, 10.12.3, 10.12.5) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://interstitials/ 2. Click on any link, it will redirects to the specified page 3. Click on back navigation button (near omnibox surface area) once or twice and observe Actual: Browser doesn't navigate to chrome://interstitials/ after clicking on back navigation button Expected: Browser should navigate to chrome://interstitials/ This is an Regression issue broken in M-63, will soon update the bisect info. Good Build - 63.0.3213.0 Bad Build - 63.0.3214.0
,
Sep 15 2017
This is an Regression issue broken in M-63, will soon update the bisect info. Good Build - 63.0.3213.0 Bad Build - 63.0.3214.0 You are probably looking for a change made after 501369 (known good), but no later than 501370 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/5ed8d110614e627a3b7ff828bd2eaf7bad5a4135..347624883210ae4aa94bfc6b0c84e9faf5ecca2b Suspect: https://chromium.googlesource.com/chromium/src/+/347624883210ae4aa94bfc6b0c84e9faf5ecca2b carlosil: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
,
Sep 15 2017
Adding RB Label as this is a recent regression. Please remove if not required. Thank You.
,
Sep 15 2017
Fix submitted as https://chromium-review.googlesource.com/#/c/chromium/src/+/668617
,
Sep 20 2017
Sorry, didn't see the bug until after claudiomdsjr submitted the fix, had an issue with my chromium mail getting forwarded. I'll mark this solved as soon as that gets merged.
,
Sep 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebe5b1ca07e62ac237745ae27e5464d119bfce4e commit ebe5b1ca07e62ac237745ae27e5464d119bfce4e Author: Claudio DeSouza <claudiomdsjr@gmail.com> Date: Wed Sep 20 19:27:05 2017 Fixed back navigation issue on chrome://interstitials InterstitialsHTMLSource was not handling back navigation. The url returned by web_contents is not yet update when replying to a data request. Rather the argument path passed in is the one that has the proper value. R=carlosil@chromium.org, rsleevi@chromium.org Bug: 765613 Change-Id: I1cb565f5a12f95ccbf56eeb5775311f2cd484d2d Reviewed-on: https://chromium-review.googlesource.com/668617 Commit-Queue: Adrienne Porter Felt <felt@chromium.org> Reviewed-by: Adrienne Porter Felt <felt@chromium.org> Cr-Commit-Position: refs/heads/master@{#503226} [modify] https://crrev.com/ebe5b1ca07e62ac237745ae27e5464d119bfce4e/chrome/browser/ui/webui/interstitials/interstitial_ui.cc
,
Sep 20 2017
,
Sep 20 2017
Not a RB-S bug, since this is debugging UI that end users don't normally see.
,
Sep 21 2017
Just to update: Retested above issue in latest chrome canary #63.0.3221.0 on Windows (7,8,8.1,10),Linux (14.04 LTS), Mac (10.12.6) OS and issue seems fixed. Kindly review an attached video.
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by claudiom...@gmail.com
, Sep 15 2017