New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 765607 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Adjust empty state illustration spacing

Project Member Reported by rachelis@chromium.org, Sep 15 2017

Issue description

See attached diagrams
 
Screen Shot 2017-09-15 at 1.29.21 PM.png
257 KB View Download
Screen Shot 2017-09-15 at 1.29.25 PM.png
153 KB View Download

Comment 1 by fi...@chromium.org, Sep 26 2017

Components: UI>Browser>NewTabPage
Labels: -Pri-3 zine-ux M-63 Pri-2
Owner: dgn@chromium.org
Status: Available (was: Untriaged)
Nicolas, can you help me to find an owner for that? Or perhaps you wanna take it? ;-)

Comment 2 by fi...@chromium.org, Sep 26 2017

Owner: mvanouwe...@chromium.org
Status: Assigned (was: Available)
Owner: peconn@chromium.org

Comment 4 by peconn@chromium.org, Sep 27 2017

Cc: peconn@chromium.org
Owner: rachelis@chromium.org
Rachel, could you please provide the measurements in dp, are the redlines available? (or failing that could you tell me the scaling factor of the device these mocks are for?)
Cc: fi...@chromium.org
Sure! There are redlines here: https://folio.googleplex.com/chrome-ux/mocks/335-NTP-Zine/_Redlines/M62#%3Ff=hidden

You can mouseover or select items to get more details. These are based on a 360x640px mockup, which can be multiplied by 3 to get to 1080x1920.

+finkm - can we find time next week to chat about dp/mock sizing? I'm not sure I understand how we go about implementing things that well, so it might be useful for us to get on the same page across UX and Eng.

Comment 6 by bauerb@chromium.org, Sep 27 2017

Thanks, Rachel! Out of curiosity – where did the "pt" measurements in the second screenshot that you attached from?
Sorry for the confusion. :) Still setting up / learning about our new speccing tool.
Labels: zine-triaged
State as of patchset #3 of https://chromium-review.googlesource.com/c/chromium/src/+/692942 .
2017-10-02_15-17-48-ModernTot.png
217 KB View Download
Owner: peconn@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdaab005b7aa391df3ff0cfca906919702c0fc53

commit fdaab005b7aa391df3ff0cfca906919702c0fc53
Author: Peter E Conn <peconn@chromium.org>
Date: Tue Oct 03 12:59:48 2017

🏡 Update All Dismissed state item spacings.

In Chrome Home Modern the all dismissed state is more compact. Split the
all dismissed layout into two separate files, one for pre-modern and one
for modern.

Bug:  765607 
Change-Id: I3e785815363c32bc2e4d067725ab94a3dc4ef9c4
Reviewed-on: https://chromium-review.googlesource.com/692942
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506013}
[modify] https://crrev.com/fdaab005b7aa391df3ff0cfca906919702c0fc53/chrome/android/java/res/layout/content_suggestions_action_card_modern.xml
[add] https://crrev.com/fdaab005b7aa391df3ff0cfca906919702c0fc53/chrome/android/java/res/layout/content_suggestions_all_dismissed_card_modern.xml
[modify] https://crrev.com/fdaab005b7aa391df3ff0cfca906919702c0fc53/chrome/android/java/res/layout/new_tab_page_all_dismissed.xml
[modify] https://crrev.com/fdaab005b7aa391df3ff0cfca906919702c0fc53/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItem.java
[modify] https://crrev.com/fdaab005b7aa391df3ff0cfca906919702c0fc53/chrome/android/java_sources.gni
[add] https://crrev.com/fdaab005b7aa391df3ff0cfca906919702c0fc53/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItemTest.java
[add] https://crrev.com/fdaab005b7aa391df3ff0cfca906919702c0fc53/chrome/test/data/android/render_tests/AllDismissedItemTest.afternoon.Nexus_5-19.png
[add] https://crrev.com/fdaab005b7aa391df3ff0cfca906919702c0fc53/chrome/test/data/android/render_tests/AllDismissedItemTest.evening.Nexus_5-19.png
[add] https://crrev.com/fdaab005b7aa391df3ff0cfca906919702c0fc53/chrome/test/data/android/render_tests/AllDismissedItemTest.modern.Nexus_5-19.png
[add] https://crrev.com/fdaab005b7aa391df3ff0cfca906919702c0fc53/chrome/test/data/android/render_tests/AllDismissedItemTest.morning.Nexus_5-19.png

Status: Fixed (was: Started)

Sign in to add a comment