[Missing Test]: viz: Printing FrameSinkId labels makes FrameSinkId valid again. |
|||
Issue descriptionAutomated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future? CL: ---- https://chromium.googlesource.com/chromium/src.git/+/76378d54c37806e7be47c0f1ecc04a4c8fa27960 Ref Bug: --------- https://bugs.chromium.org/p/chromium/issues/detail?id=764444 Thank you.
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6684db980d6661070a671ddc068aa75dc9f87875 commit 6684db980d6661070a671ddc068aa75dc9f87875 Author: Alex Zhang <staraz@chromium.org> Date: Wed Sep 27 18:12:32 2017 Add Surface Reference Debug Label Unit Test Added a automated test for FrameSink debug labels. The test sets up a surface reference with a label. It gets the surface references string from SurfaceManager and checks that the label is in the string. It then invalidate the FrameSinkLabel that has the label and makes sure the label no longer exists in the surface references string afterwards. Bug: 765606 Change-Id: Ica18de18803dd6cf86ddcb18c863124c427bdd98 Reviewed-on: https://chromium-review.googlesource.com/668656 Commit-Queue: Xingyu Zhang <staraz@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#504732} [modify] https://crrev.com/6684db980d6661070a671ddc068aa75dc9f87875/components/viz/service/frame_sinks/surface_references_unittest.cc [modify] https://crrev.com/6684db980d6661070a671ddc068aa75dc9f87875/components/viz/service/surfaces/surface_manager.cc [modify] https://crrev.com/6684db980d6661070a671ddc068aa75dc9f87875/components/viz/service/surfaces/surface_manager.h
,
Sep 27 2017
,
Nov 8 2017
Migrating from Internals>Viz to Internals>Services>Viz. |
|||
►
Sign in to add a comment |
|||
Comment 1 by staraz@chromium.org
, Sep 15 2017Status: Started (was: Assigned)