New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 765588 link

Starred by 0 users
Status: Fixed
Owner:
treib@chromium.org
Closed: Mar 2018
Cc:
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocked on:
issue 718413


Sign in to add a comment

Clean up after NTPCaptureThumbnail launch

Project Member Reported by treib@chromium.org, Sep 15 2017 
The current plan is to launch in M64.

TODOs after Stable launch:
- Enable launched features by default: CaptureThumbnailOnNavigatingAway and CaptureThumbnailDependingOnTransitionType.
- Remove fieldtrial testing config.
- (Maybe one version later) Remove feature checks for CaptureThumbnailOnNavigatingAway and CaptureThumbnailDependingOnTransitionType.

Comment 1 by treib@chromium.org, Sep 15 2017

Blockedon: 718413
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6263ab04beb58e7ed19b027f211d080aa954dc74

commit 6263ab04beb58e7ed19b027f211d080aa954dc74
Author: Marc Treib <treib@chromium.org>
Date: Mon Sep 18 10:09:16 2017

Enable NTPCaptureThumbnail by default

This enables the features "CaptureThumbnailOnNavigatingAway" and
"CaptureThumbnailDependingOnTransitionType" by default, and removes the
corresponding fieldtrial testing config.

Bug:  765588 
Change-Id: I635e51db6615414fee0178c3528421178027885b
Reviewed-on: https://chromium-review.googlesource.com/668369
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502549}
[modify] https://crrev.com/6263ab04beb58e7ed19b027f211d080aa954dc74/chrome/common/chrome_features.cc
[modify] https://crrev.com/6263ab04beb58e7ed19b027f211d080aa954dc74/testing/variations/fieldtrial_testing_config.json

Comment 3 by fi...@chromium.org, Sep 18 2017

Labels: zine-triaged

Comment 5 by treib@chromium.org, Sep 21 2017

NextAction: 2017-10-15
The M63 parts are done. Let's give it a few weeks on M61 Stable, then (assuming nothing goes wrong) we can also remove the checks for the launched features entirely.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9b5f09729c9d0538fc0e7b6f5d8ff723b0aaf2a

commit f9b5f09729c9d0538fc0e7b6f5d8ff723b0aaf2a
Author: Marc Treib <treib@chromium.org>
Date: Fri Oct 13 16:40:54 2017

Cleanup: Remove launched CaptureThumbnail feature checks

CaptureThumbnailDependingOnTransitionType and CaptureThumbnailOnNavigatingAway
have been launched. This CL removes the feature checks.

Bug:  765588 
Change-Id: I68906ef0533ede82dc3c47724603b9af78494969
Reviewed-on: https://chromium-review.googlesource.com/684839
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508722}
[modify] https://crrev.com/f9b5f09729c9d0538fc0e7b6f5d8ff723b0aaf2a/chrome/browser/about_flags.cc
[modify] https://crrev.com/f9b5f09729c9d0538fc0e7b6f5d8ff723b0aaf2a/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/f9b5f09729c9d0538fc0e7b6f5d8ff723b0aaf2a/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/f9b5f09729c9d0538fc0e7b6f5d8ff723b0aaf2a/chrome/browser/thumbnails/thumbnail_service_impl.cc
[modify] https://crrev.com/f9b5f09729c9d0538fc0e7b6f5d8ff723b0aaf2a/chrome/browser/thumbnails/thumbnail_service_unittest.cc
[modify] https://crrev.com/f9b5f09729c9d0538fc0e7b6f5d8ff723b0aaf2a/chrome/browser/thumbnails/thumbnail_tab_helper.cc
[modify] https://crrev.com/f9b5f09729c9d0538fc0e7b6f5d8ff723b0aaf2a/chrome/browser/thumbnails/thumbnail_tab_helper.h
[modify] https://crrev.com/f9b5f09729c9d0538fc0e7b6f5d8ff723b0aaf2a/chrome/common/chrome_features.cc
[modify] https://crrev.com/f9b5f09729c9d0538fc0e7b6f5d8ff723b0aaf2a/chrome/common/chrome_features.h

Comment 7 by monor...@bugs.chromium.org, Oct 15 2017 

The NextAction date has arrived: 2017-10-15

Comment 8 by treib@chromium.org, Oct 16 2017

Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/026acc538cc649f33869649b77ca3286180b0d98

commit 026acc538cc649f33869649b77ca3286180b0d98
Author: Marc Treib <treib@chromium.org>
Date: Tue Oct 17 18:39:59 2017

Revert "Cleanup: Remove launched CaptureThumbnail feature checks"

This reverts commit f9b5f09729c9d0538fc0e7b6f5d8ff723b0aaf2a.

Reason for revert: crbug.com/774798 - let's keep the feature checks
around for now.

Original change's description:
> Cleanup: Remove launched CaptureThumbnail feature checks
> 
> CaptureThumbnailDependingOnTransitionType and CaptureThumbnailOnNavigatingAway
> have been launched. This CL removes the feature checks.
> 
> Bug:  765588 
> Change-Id: I68906ef0533ede82dc3c47724603b9af78494969
> Reviewed-on: https://chromium-review.googlesource.com/684839
> Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
> Commit-Queue: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#508722}

TBR=treib@chromium.org,fhorschig@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  765588 
Change-Id: Iaab1b35b3fb00e817e3311e11fffa3a23553ef99
Reviewed-on: https://chromium-review.googlesource.com/723384
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509444}
[modify] https://crrev.com/026acc538cc649f33869649b77ca3286180b0d98/chrome/browser/about_flags.cc
[modify] https://crrev.com/026acc538cc649f33869649b77ca3286180b0d98/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/026acc538cc649f33869649b77ca3286180b0d98/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/026acc538cc649f33869649b77ca3286180b0d98/chrome/browser/thumbnails/thumbnail_service_impl.cc
[modify] https://crrev.com/026acc538cc649f33869649b77ca3286180b0d98/chrome/browser/thumbnails/thumbnail_service_unittest.cc
[modify] https://crrev.com/026acc538cc649f33869649b77ca3286180b0d98/chrome/browser/thumbnails/thumbnail_tab_helper.cc
[modify] https://crrev.com/026acc538cc649f33869649b77ca3286180b0d98/chrome/browser/thumbnails/thumbnail_tab_helper.h
[modify] https://crrev.com/026acc538cc649f33869649b77ca3286180b0d98/chrome/common/chrome_features.cc
[modify] https://crrev.com/026acc538cc649f33869649b77ca3286180b0d98/chrome/common/chrome_features.h

Comment 10 by treib@chromium.org, Oct 18 2017

NextAction: 2017-12-15
Status: Started (was: Fixed)

Comment 11 by treib@chromium.org, Nov 22 2017

Description: Show this description

Comment 12 by treib@chromium.org, Nov 22 2017

NextAction: 2018-02-01

Comment 13 by monor...@bugs.chromium.org, Feb 1 2018 

The NextAction date has arrived: 2018-02-01

Comment 14 by treib@chromium.org, Feb 1 2018

NextAction: 2018-03-01
Project Member

Comment 15 by bugdroid1@chromium.org, Feb 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05582e889f8f3ebb1265fdc907fc457443d6eda5

commit 05582e889f8f3ebb1265fdc907fc457443d6eda5
Author: Marc Treib <treib@chromium.org>
Date: Tue Feb 13 16:45:01 2018

Enable NTPCaptureThumbnail by default

This includes the two features CaptureThumbnailDependingOnTransitionType
and CaptureThumbnailOnNavigatingAway.

Bug:  765588 
Change-Id: I53faf967fbfef9281257d486acfa750af2512cae
Reviewed-on: https://chromium-review.googlesource.com/911803
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536385}
[modify] https://crrev.com/05582e889f8f3ebb1265fdc907fc457443d6eda5/chrome/common/chrome_features.cc
[modify] https://crrev.com/05582e889f8f3ebb1265fdc907fc457443d6eda5/testing/variations/fieldtrial_testing_config.json

Comment 16 by monor...@bugs.chromium.org, Mar 1 2018 

The NextAction date has arrived: 2018-03-01

Comment 17 by treib@chromium.org, Mar 1 2018

NextAction: ----
https://crrev.com/c/943042
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e663698b54fdef7fcd93e3491fa546379757868e

commit e663698b54fdef7fcd93e3491fa546379757868e
Author: Marc Treib <treib@chromium.org>
Date: Mon Mar 05 11:18:50 2018

Cleanup: Remove launched NTPCaptureThumbnail features

This CL removess the two features CaptureThumbnailDependingOnTransitionType
and CaptureThumbnailOnNavigatingAway and updates all the places that
checked them.

Bug:  765588 
Change-Id: Iaf4756410093d7ffb9caef7a9a221ebd9c62efe4
Reviewed-on: https://chromium-review.googlesource.com/943042
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540802}
[modify] https://crrev.com/e663698b54fdef7fcd93e3491fa546379757868e/chrome/browser/about_flags.cc
[modify] https://crrev.com/e663698b54fdef7fcd93e3491fa546379757868e/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/e663698b54fdef7fcd93e3491fa546379757868e/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/e663698b54fdef7fcd93e3491fa546379757868e/chrome/browser/thumbnails/thumbnail_browsertest.cc
[modify] https://crrev.com/e663698b54fdef7fcd93e3491fa546379757868e/chrome/browser/thumbnails/thumbnail_service_impl.cc
[modify] https://crrev.com/e663698b54fdef7fcd93e3491fa546379757868e/chrome/browser/thumbnails/thumbnail_service_unittest.cc
[modify] https://crrev.com/e663698b54fdef7fcd93e3491fa546379757868e/chrome/browser/thumbnails/thumbnail_tab_helper.cc
[modify] https://crrev.com/e663698b54fdef7fcd93e3491fa546379757868e/chrome/browser/thumbnails/thumbnail_tab_helper.h
[modify] https://crrev.com/e663698b54fdef7fcd93e3491fa546379757868e/chrome/common/chrome_features.cc
[modify] https://crrev.com/e663698b54fdef7fcd93e3491fa546379757868e/chrome/common/chrome_features.h

Comment 19 by treib@chromium.org, Mar 5 2018

Labels: OS-Android
Status: Fixed (was: Started)
►

Sign in to add a comment