Issue metadata
Sign in to add a comment
|
100% improvement in browser_tests at 493173:493577 |
||||||||||||||||||||
Issue descriptionbraveyao@, could this be caused by https://webrtc.googlesource.com/src/webrtc/+/9c5a49a302b59e2b508d01d25b2716efad565201?
,
Sep 15 2017
The change is only visible for Win10. All other platforms, including Win7 and Win8 have unchanged behavior.
,
Sep 15 2017
Does the "improvement" here mean good or bad? And the change is to audio jitter? My Cl should only affect the case that during window sharing, the shared window is minimized. Yes it can save some CPU cycles, but I don't think it can affect the overall performance, especially to audio part. Also I doubt the browser_tests can do window sharing and minimize the window during testing. Is it possible to nail down the specific test in browser_tests?
,
Oct 11 2017
Jitter is bad in general, so in this case the change is for the better. Since this is a very limited change (in absolute numbers), and only for one bot, I'd say we close this. Feel free to re-open if you disagree. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Sep 15 2017