The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3afb8e4faa0d0a83686a9815a3af8a78917f7f10

commit 3afb8e4faa0d0a83686a9815a3af8a78917f7f10
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Sep 15 11:02:40 2017

[Password Manager] Fix bug in sending autofill votes

Before this CL, most of username correction votes were suppressed because of a bug.

New tests that will prevent similar issues will be added later. Opened  crbug.com/765578  for that.

Bug: 699530,  765578 
Change-Id: Ic08261f25425f13a26e4ba04ffda3a6f6258ed1a
Reviewed-on: https://chromium-review.googlesource.com/668365
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502223}
[modify] https://crrev.com/3afb8e4faa0d0a83686a9815a3af8a78917f7f10/components/password_manager/core/browser/password_form_manager.cc

Merge request for https://chromium-review.googlesource.com/668365. 

Very small change. It doesn't affect on user experience directly, but only on  crowdsourcing votes. The votes fix Password Manager's core function - username field detection. 

This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Update for #3: the tests are coming in https://chromium-review.googlesource.com/c/chromium/src/+/670562.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7bd7b007f8ae421b6978a2d2eb52c1454f3a969

commit d7bd7b007f8ae421b6978a2d2eb52c1454f3a969
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Mon Sep 18 14:37:24 2017

[Password Manager] Add tests for uploading username correction votes

New tests check that username correction votes are uploaded when form has only two fields.

Two fields case (sign-in form) is actually the main case for uploading username votes, but https://codereview.chromium.org/2886413002 didn't send username votes when the form has only two fields. New tests should prevent breaking username votes logic in the future.

Bug: 699530,  765578 
Change-Id: I1b75edfc6e322c587c1e59adb9bb491c96891765
Reviewed-on: https://chromium-review.googlesource.com/670562
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502575}
[modify] https://crrev.com/d7bd7b007f8ae421b6978a2d2eb52c1454f3a969/components/password_manager/core/browser/password_form_manager_unittest.cc

Thanks for the fix. Can we please wait until M63? Since this has been broken for half a year and it's already post branch, we're only taking new regressions or critical fixes. Can you please confirm if this is okay to take in M63?

This broke 4 months ago and we have Sridhar (the SVP one) nagging us about this. This 1-liner will provide a major boost to the correctness of the password manager: When you create an account with a website, Chrome offers you to save the username and password. Today, we pick the wrong username (e.g. your city instead of your username) in ~20% of cases. With this fix, that number should go down to 4%.

The user can still work around this issue by manually editing the username, though. So this is a major improvement on the robustness / PE side, but not a release blocker.

Thanks for the details. Approving merge to M62: branch 3202.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d1155aa81c64965d6b1610a07dc332eda4e9975

commit 6d1155aa81c64965d6b1610a07dc332eda4e9975
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Wed Sep 20 08:40:17 2017

[Merge to M62] [Password Manager] Fix bug in sending autofill votes

Before this CL, most of username correction votes were suppressed because of a bug.

New tests that will prevent similar issues will be added later. Opened  crbug.com/765578  for that.

TBR=kolos@chromium.org

(cherry picked from commit 3afb8e4faa0d0a83686a9815a3af8a78917f7f10)

Bug: 699530,  765578 
Change-Id: Ic08261f25425f13a26e4ba04ffda3a6f6258ed1a
Reviewed-on: https://chromium-review.googlesource.com/668365
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502223}
Reviewed-on: https://chromium-review.googlesource.com/674685
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#352}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/6d1155aa81c64965d6b1610a07dc332eda4e9975/components/password_manager/core/browser/password_form_manager.cc

kolos@ Could you please help us with the repro steps of this issue to verify the fix from TE-End

the fix is about sending votes, no direct affect on UX.