New issue
Advanced search Search tips

Issue 765533 link

Starred by 2 users

Issue metadata

Status: Started
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Mojo content/common/file_utilities_messages.h

Project Member Reported by slangley@chromium.org, Sep 15 2017

Issue description

There's only one message in this file.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6f32c59b87f5fc8b029281a6b12ae512a093e89

commit e6f32c59b87f5fc8b029281a6b12ae512a093e89
Author: Stuart Langley <slangley@chromium.org>
Date: Wed Sep 27 04:35:18 2017

Convert file_utilities_messages to mojo

Because we now have mojo I altered the API to return an optional FileInfo and
dropped FileError from the API entirely.

Added base::File::Info as a common mojo message so it's available for other
users in future, it already had the IPC code to serialize the messages.

Honored the existing task dispatch for messages on both sides, using a
ThreadSafe interface on the send side and a sequenced task runner on the
receiver side.

In a follow-up CL we can look at removing WebFileInfo as we *might* be able
to use base::File::Info for all of these use cases.

Bug: 765533
Change-Id: I161f22c1ae0ac4f47f856aa70b976727dc462324
Reviewed-on: https://chromium-review.googlesource.com/663005
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504581}
[modify] https://crrev.com/e6f32c59b87f5fc8b029281a6b12ae512a093e89/content/browser/BUILD.gn
[add] https://crrev.com/e6f32c59b87f5fc8b029281a6b12ae512a093e89/content/browser/renderer_host/file_utilities_host_impl.cc
[add] https://crrev.com/e6f32c59b87f5fc8b029281a6b12ae512a093e89/content/browser/renderer_host/file_utilities_host_impl.h
[delete] https://crrev.com/5b5076342f57e659d25d45ecc1133901714aae9d/content/browser/renderer_host/file_utilities_message_filter.cc
[delete] https://crrev.com/5b5076342f57e659d25d45ecc1133901714aae9d/content/browser/renderer_host/file_utilities_message_filter.h
[modify] https://crrev.com/e6f32c59b87f5fc8b029281a6b12ae512a093e89/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/e6f32c59b87f5fc8b029281a6b12ae512a093e89/content/child/webfileutilities_impl.cc
[modify] https://crrev.com/e6f32c59b87f5fc8b029281a6b12ae512a093e89/content/common/BUILD.gn
[modify] https://crrev.com/e6f32c59b87f5fc8b029281a6b12ae512a093e89/content/common/content_message_generator.h
[add] https://crrev.com/e6f32c59b87f5fc8b029281a6b12ae512a093e89/content/common/file_utilities.mojom
[delete] https://crrev.com/5b5076342f57e659d25d45ecc1133901714aae9d/content/common/file_utilities_messages.h
[modify] https://crrev.com/e6f32c59b87f5fc8b029281a6b12ae512a093e89/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/e6f32c59b87f5fc8b029281a6b12ae512a093e89/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/e6f32c59b87f5fc8b029281a6b12ae512a093e89/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/e6f32c59b87f5fc8b029281a6b12ae512a093e89/mojo/common/BUILD.gn
[add] https://crrev.com/e6f32c59b87f5fc8b029281a6b12ae512a093e89/mojo/common/file_info.mojom
[add] https://crrev.com/e6f32c59b87f5fc8b029281a6b12ae512a093e89/mojo/common/file_info.typemap
[modify] https://crrev.com/e6f32c59b87f5fc8b029281a6b12ae512a093e89/mojo/common/typemaps.gni

Components: Blink>Internals>Modularization
Labels: -Type-Bug Type-Task
Owner: ----
Still needs onion souping.

Sign in to add a comment