New issue
Advanced search Search tips

Issue 765516 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

lots of random model.dtsi errors

Project Member Reported by vapier@chromium.org, Sep 15 2017

Issue description

looks like something is busted here
$ emerge-samus chromeos-firmware-samus -1 --nodeps
cat: /mnt/host/source/src/private-overlays/overlay-samus-private/chromeos-base/chromeos-firmware-samus/../chromeos-config-bsp/files/model.dtsi: No such file or directory
cat: /mnt/host/source/src/private-overlays/overlay-samus-private/chromeos-base/chromeos-firmware-samus/../chromeos-config-bsp/files/model.dtsi: No such file or directory

>>> Emerging (1 of 1) chromeos-base/chromeos-firmware-samus-0.0.1-r141::samus-private for /build/samus/
....

happens with a lot of firmware ebuilds.
 

Comment 1 by sjg@chromium.org, Sep 15 2017

Yes this happens with all non-unibuild firmware builds. I introduced this when I tried to add a check for the config, realised that I couldn't (since the USE=unibuild flag is not accessible to the code that sets up SRC_URI) and left in the code that generates the error.

Will fix.

Comment 2 by sjg@chromium.org, Sep 21 2017

Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5e667130454777165fe122d3b4a731b983a9a660

commit 5e667130454777165fe122d3b4a731b983a9a660
Author: Simon Glass <sjg@chromium.org>
Date: Fri Sep 22 00:19:52 2017

cros-unibuild: Avoid an error when master config is missing

This file is only present with unified builds. We cope with it being
missing, but not silently:

/mnt/host/source/src/private-overlays/overlay-samus-private/chromeos-base/
	chromeos-firmware-samus/../chromeos-config-bsp/files/model.dtsi:
	No such file or directory

Fix this by only including the file if it is present.

BUG= chromium:765516 
TEST=emerge-reef chromeos-firmware
See that there is no error printed

Change-Id: I7c0d14580fdcdb1e5044e2a0f2ac4b9a00773e66
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/675810
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/5e667130454777165fe122d3b4a731b983a9a660/eclass/cros-unibuild.eclass

Comment 4 by sjg@chromium.org, Sep 26 2017

Status: Fixed (was: Started)
This is fixed. We still have the following error:

20:57:31: INFO: RunCommand: /b/c/cbuild/repository/chromite/bin/cros_sdk -- /usr/bin/fdtget -l /build/reef/usr/share/chromeos-config/config.dtb /chromeos/models in /b/c/cbuild/repository
20:57:33: INFO: (stderr):
Couldn't open blob from '/build/reef/usr/share/chromeos-config/config.dtb': No such file or directory

This is harmless and does not include the word 'error', so I think it is OK for now. It will be cleaned up when we move that code to use cros_config_host.

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 6 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment