New issue
Advanced search Search tips

Issue 765509 link

Starred by 1 user
Status: Fixed
Owner:
wutao@chromium.org
Closed: Sep 2017
Cc:
jdufault@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

keyboardOverlayUnPin is misspelled in keyboard overlay

Project Member Reported by jdufault@chromium.org, Sep 15 2017 
keyboardOverlayUnPin is misspelled in keyboard overlay. It should be keyboardOverlayUnpin.

https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc?q=keyboardOverlayUnPin&l=277

This generates a bunch of bad log messages.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f6a39ed4ae7c30207cd4f1d4c1aa2a20bb13d60

commit 5f6a39ed4ae7c30207cd4f1d4c1aa2a20bb13d60
Author: wutao <wutao@chromium.org>
Date: Fri Sep 15 16:27:48 2017

Fix keyboardOverlayUnpin typo.

Fix a typo of keyboardOverlayUnpin.

Bug:  765509 
Test: On device.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2c429acd8e469219bbb506ae64e9a2fb6bd867f6
Reviewed-on: https://chromium-review.googlesource.com/667984
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502275}
[modify] https://crrev.com/5f6a39ed4ae7c30207cd4f1d4c1aa2a20bb13d60/chrome/browser/resources/chromeos/keyboard_overlay_data.js

Comment 2 by wutao@chromium.org, Sep 15 2017

Labels: OS-Chrome
Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment