New issue
Advanced search Search tips

Issue 765506 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

DevTools: JSON strings are not escaped in utf8 specializations of inspector_protocol

Project Member Reported by pfeldman@chromium.org, Sep 15 2017

Issue description

1. open any page and evaluate document.cookie = 'привет'; in sonsole.
2. Open Application panel -> Cookies and check the cookie value.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/deps/inspector_protocol/+/6eed77ccc1b08990170c2c25b81e9e04f63a661f

commit 6eed77ccc1b08990170c2c25b81e9e04f63a661f
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Fri Sep 15 17:04:48 2017

Allow escaping utf8 strings in embedders that operate std::string.

Bug:  chromium:765506 
Change-Id: I47d54d59bd99cdd63ecd48833bf0fae8a0bad5b1
TBR: kozyatinskiy

[modify] https://crrev.com/6eed77ccc1b08990170c2c25b81e9e04f63a661f/lib/Values_cpp.template
[modify] https://crrev.com/6eed77ccc1b08990170c2c25b81e9e04f63a661f/lib/Values_h.template

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/deps/inspector_protocol/+/f45aad00cc818c359d1b1f140c8dc96d0994b4cb

commit f45aad00cc818c359d1b1f140c8dc96d0994b4cb
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Fri Sep 15 21:13:47 2017

Provide default escape implementation for latin and wide strings.

Bug:  765506 
Change-Id: Ibb7a486e6d04b04692d95188a469fffed2a1bca9

[modify] https://crrev.com/f45aad00cc818c359d1b1f140c8dc96d0994b4cb/lib/Values_cpp.template
[modify] https://crrev.com/f45aad00cc818c359d1b1f140c8dc96d0994b4cb/lib/Values_h.template

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74e192b49bfceb69da7ccf1efed1a2d7c07a9e83

commit 74e192b49bfceb69da7ccf1efed1a2d7c07a9e83
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Tue Sep 19 19:58:58 2017

DevTools: escape protocol strings that are originally utf8.

Bug:  765506 
Change-Id: I16fbe56180f96eb1daf504510a6d07965e226622
TBR: (api is changing)
Reviewed-on: https://chromium-review.googlesource.com/667804
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502929}
[modify] https://crrev.com/74e192b49bfceb69da7ccf1efed1a2d7c07a9e83/components/ui_devtools/string_util.cc
[modify] https://crrev.com/74e192b49bfceb69da7ccf1efed1a2d7c07a9e83/components/ui_devtools/string_util.h
[modify] https://crrev.com/74e192b49bfceb69da7ccf1efed1a2d7c07a9e83/content/browser/devtools/protocol_string.cc
[modify] https://crrev.com/74e192b49bfceb69da7ccf1efed1a2d7c07a9e83/content/browser/devtools/protocol_string.h
[modify] https://crrev.com/74e192b49bfceb69da7ccf1efed1a2d7c07a9e83/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/cookies-protocol-test-expected.txt
[modify] https://crrev.com/74e192b49bfceb69da7ccf1efed1a2d7c07a9e83/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/cookies-protocol-test.js
[modify] https://crrev.com/74e192b49bfceb69da7ccf1efed1a2d7c07a9e83/third_party/WebKit/Source/core/inspector/V8InspectorString.cpp
[modify] https://crrev.com/74e192b49bfceb69da7ccf1efed1a2d7c07a9e83/third_party/WebKit/Source/core/inspector/V8InspectorString.h
[modify] https://crrev.com/74e192b49bfceb69da7ccf1efed1a2d7c07a9e83/third_party/inspector_protocol/README.chromium
[modify] https://crrev.com/74e192b49bfceb69da7ccf1efed1a2d7c07a9e83/third_party/inspector_protocol/lib/Values_cpp.template
[modify] https://crrev.com/74e192b49bfceb69da7ccf1efed1a2d7c07a9e83/third_party/inspector_protocol/lib/Values_h.template

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a4c4e80d4afcb36719f65c1ef0540e191c2eb5d

commit 0a4c4e80d4afcb36719f65c1ef0540e191c2eb5d
Author: calamity <calamity@chromium.org>
Date: Wed Sep 20 03:43:07 2017

Revert "DevTools: escape protocol strings that are originally utf8."

This reverts commit 74e192b49bfceb69da7ccf1efed1a2d7c07a9e83.

Reason for revert: Seems to be causing failures on inspector-protocol/layout-fonts/cjk-ideograph-fallback-by-lang.js:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/25748


Original change's description:
> DevTools: escape protocol strings that are originally utf8.
> 
> Bug:  765506 
> Change-Id: I16fbe56180f96eb1daf504510a6d07965e226622
> TBR: (api is changing)
> Reviewed-on: https://chromium-review.googlesource.com/667804
> Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#502929}

TBR=dgozman@chromium.org,pfeldman@chromium.org,kozyatinskiy@chromium.org

Change-Id: I12a53eb8df15c641feaf10d9475f83ac246e5652
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  765506 
Reviewed-on: https://chromium-review.googlesource.com/674407
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503035}
[modify] https://crrev.com/0a4c4e80d4afcb36719f65c1ef0540e191c2eb5d/components/ui_devtools/string_util.cc
[modify] https://crrev.com/0a4c4e80d4afcb36719f65c1ef0540e191c2eb5d/components/ui_devtools/string_util.h
[modify] https://crrev.com/0a4c4e80d4afcb36719f65c1ef0540e191c2eb5d/content/browser/devtools/protocol_string.cc
[modify] https://crrev.com/0a4c4e80d4afcb36719f65c1ef0540e191c2eb5d/content/browser/devtools/protocol_string.h
[modify] https://crrev.com/0a4c4e80d4afcb36719f65c1ef0540e191c2eb5d/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/cookies-protocol-test-expected.txt
[modify] https://crrev.com/0a4c4e80d4afcb36719f65c1ef0540e191c2eb5d/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/cookies-protocol-test.js
[modify] https://crrev.com/0a4c4e80d4afcb36719f65c1ef0540e191c2eb5d/third_party/WebKit/Source/core/inspector/V8InspectorString.cpp
[modify] https://crrev.com/0a4c4e80d4afcb36719f65c1ef0540e191c2eb5d/third_party/WebKit/Source/core/inspector/V8InspectorString.h
[modify] https://crrev.com/0a4c4e80d4afcb36719f65c1ef0540e191c2eb5d/third_party/inspector_protocol/README.chromium
[modify] https://crrev.com/0a4c4e80d4afcb36719f65c1ef0540e191c2eb5d/third_party/inspector_protocol/lib/Values_cpp.template
[modify] https://crrev.com/0a4c4e80d4afcb36719f65c1ef0540e191c2eb5d/third_party/inspector_protocol/lib/Values_h.template

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/453ef2e909d89caf18e3987bf9ee77e4a0637c49

commit 453ef2e909d89caf18e3987bf9ee77e4a0637c49
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Fri Sep 22 18:10:38 2017

Reland "DevTools: escape protocol strings that are originally utf8."

This is a reland of 74e192b49bfceb69da7ccf1efed1a2d7c07a9e83
Original change's description:
> DevTools: escape protocol strings that are originally utf8.
> 
> Bug:  765506 
> Change-Id: I16fbe56180f96eb1daf504510a6d07965e226622
TBR: (api is changing)
> Reviewed-on: https://chromium-review.googlesource.com/667804
> Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#502929}

Bug:  765506 
Change-Id: Ib2fbf5b700bdfae31b55f2d8ccd3327bbd86b884
Reviewed-on: https://chromium-review.googlesource.com/675774
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503794}
[modify] https://crrev.com/453ef2e909d89caf18e3987bf9ee77e4a0637c49/components/ui_devtools/string_util.cc
[modify] https://crrev.com/453ef2e909d89caf18e3987bf9ee77e4a0637c49/components/ui_devtools/string_util.h
[modify] https://crrev.com/453ef2e909d89caf18e3987bf9ee77e4a0637c49/content/browser/devtools/protocol_string.cc
[modify] https://crrev.com/453ef2e909d89caf18e3987bf9ee77e4a0637c49/content/browser/devtools/protocol_string.h
[modify] https://crrev.com/453ef2e909d89caf18e3987bf9ee77e4a0637c49/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/cookies-protocol-test-expected.txt
[modify] https://crrev.com/453ef2e909d89caf18e3987bf9ee77e4a0637c49/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/cookies-protocol-test.js
[modify] https://crrev.com/453ef2e909d89caf18e3987bf9ee77e4a0637c49/third_party/WebKit/Source/core/inspector/V8InspectorString.cpp
[modify] https://crrev.com/453ef2e909d89caf18e3987bf9ee77e4a0637c49/third_party/WebKit/Source/core/inspector/V8InspectorString.h
[modify] https://crrev.com/453ef2e909d89caf18e3987bf9ee77e4a0637c49/third_party/inspector_protocol/README.chromium
[modify] https://crrev.com/453ef2e909d89caf18e3987bf9ee77e4a0637c49/third_party/inspector_protocol/lib/Values_cpp.template
[modify] https://crrev.com/453ef2e909d89caf18e3987bf9ee77e4a0637c49/third_party/inspector_protocol/lib/Values_h.template

Labels: Merge-Request-62
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 25 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-62 Merge-Rejected-62
There are a lot of CLs and it's unclear what needs to be merged and why. This doesn't seem to be critical enough for M62, since we are already past branch point. Can you please confirm why this is needed and why can it not wait until M63? 
This regresses ChromeDriver implementation and needs to be merged. That's just one CL, it was at first bulk-reverted by sheriff with no good reason.
Labels: -Merge-Rejected-62 Merge-Request-62
Project Member

Comment 11 by sheriffbot@chromium.org, Oct 4 2017

Labels: -Merge-Request-62 Merge-Review-62
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Assigned)
Status: Started (was: Fixed)
It is important that we merge.
Labels: -Pri-3 Pri-1
Labels: -Merge-Review-62 Merge-Approved-62
Thanks for details. Approving for merge to M62. Branch:3202. Confirmed with pfeldman@ its a safe merge, well tested.
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 5 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bb38c484b9682e4834ae7e22a501448e32f4828

commit 5bb38c484b9682e4834ae7e22a501448e32f4828
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Thu Oct 05 23:14:06 2017

Reland "DevTools: escape protocol strings that are originally utf8."

This is a reland of 74e192b49bfceb69da7ccf1efed1a2d7c07a9e83
Original change's description:
> DevTools: escape protocol strings that are originally utf8.
>
> Bug:  765506 
> Change-Id: I16fbe56180f96eb1daf504510a6d07965e226622
TBR: (api is changing)
> Reviewed-on: https://chromium-review.googlesource.com/667804
> Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#502929}

TBR=pfeldman@chromium.org

(cherry picked from commit 453ef2e909d89caf18e3987bf9ee77e4a0637c49)

Bug:  765506 
Change-Id: Ib2fbf5b700bdfae31b55f2d8ccd3327bbd86b884
Reviewed-on: https://chromium-review.googlesource.com/675774
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503794}
Reviewed-on: https://chromium-review.googlesource.com/704003
Cr-Commit-Position: refs/branch-heads/3202@{#602}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/5bb38c484b9682e4834ae7e22a501448e32f4828/components/ui_devtools/string_util.cc
[modify] https://crrev.com/5bb38c484b9682e4834ae7e22a501448e32f4828/components/ui_devtools/string_util.h
[modify] https://crrev.com/5bb38c484b9682e4834ae7e22a501448e32f4828/content/browser/devtools/protocol_string.cc
[modify] https://crrev.com/5bb38c484b9682e4834ae7e22a501448e32f4828/content/browser/devtools/protocol_string.h
[modify] https://crrev.com/5bb38c484b9682e4834ae7e22a501448e32f4828/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/cookies-protocol-test-expected.txt
[modify] https://crrev.com/5bb38c484b9682e4834ae7e22a501448e32f4828/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/cookies-protocol-test.js
[modify] https://crrev.com/5bb38c484b9682e4834ae7e22a501448e32f4828/third_party/WebKit/Source/core/inspector/V8InspectorString.cpp
[modify] https://crrev.com/5bb38c484b9682e4834ae7e22a501448e32f4828/third_party/WebKit/Source/core/inspector/V8InspectorString.h
[modify] https://crrev.com/5bb38c484b9682e4834ae7e22a501448e32f4828/third_party/inspector_protocol/README.chromium
[modify] https://crrev.com/5bb38c484b9682e4834ae7e22a501448e32f4828/third_party/inspector_protocol/lib/Values_cpp.template
[modify] https://crrev.com/5bb38c484b9682e4834ae7e22a501448e32f4828/third_party/inspector_protocol/lib/Values_h.template

Status: Fixed (was: Started)
Cc: pfeldman@chromium.org
 Issue chromedriver:1977  has been merged into this issue.

Sign in to add a comment