[SoM] Error "TypeError: Cannot read property 'map' of null" after grouping two alerts |
|||||
Issue descriptionI tried to group two alerts, and saw this error at the top of the page. Now I'm seeing this error when trying to simply add a bug number to an alert. Looks like some data was lost when the grouping failed. This is the first time I've tried grouping, so maybe I did something wrong, or maybe there's a problem grouping already grouped alerts? Adding a bug number to an alert still seems to work fine on the sheriff-o-matic-staging but it's not reflected in the production version and the production version keeps giving this error when I try to do the operation there. Also it seems that comments were lost on the alerts that I tried to group together.
,
Sep 15 2017
I can't link issues to alerts or add comments to alerts either - same error message. donnd@ fyi I'm instead keeping track of issues at go/clank-sheriff-status during my sheriffing shift today.
,
Sep 15 2017
Thanks for reporting this! I'll look into this now. +martiniss since he's been working on adding error handling to regression range grouping, which I think might be related to this: https://chromium-review.googlesource.com/c/infra/infra/+/661879
,
Sep 15 2017
,
Sep 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/ffa31aa9346c197c5fa99374b6d3d49803bdea1f commit ffa31aa9346c197c5fa99374b6d3d49803bdea1f Author: Tiff Zhang <zhangtiff@google.com> Date: Sat Sep 16 00:23:31 2017 SoM: Add null checks to groupRange. Bug:765485 Change-Id: I73dcb91163df37a96b14871f7a52de490bbbd463 Reviewed-on: https://chromium-review.googlesource.com/669280 Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/ffa31aa9346c197c5fa99374b6d3d49803bdea1f/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.js
,
Sep 16 2017
I can associate bugs with alerts again, which is really useful -- thanks for fixing that (assuming this null check did it).
,
Sep 20 2017
I get this error when trying to snooze an alert. Stack trace:
Uncaught (in promise) TypeError: Cannot read property 'map' of null
at HTMLElement._mergeRegressionRange (som-app.vulcanized.html:34912)
at Array.reduce (<anonymous>)
at HTMLElement._mergeRegressionRanges (som-app.vulcanized.html:34902)
at HTMLElement._computeAlert (som-app.vulcanized.html:34858)
at HTMLElement._computeAlertsSet (som-app.vulcanized.html:34802)
at HTMLElement._computeAlerts (som-app.vulcanized.html:34783)
at runMethodEffect (som-app.vulcanized.html:3014)
at Object.runComputedEffect [as fn] (som-app.vulcanized.html:2643)
at runEffectsForProperty (som-app.vulcanized.html:2378)
at runEffects (som-app.vulcanized.html:2344)
,
Sep 20 2017
I just deployed a new release of Sheriff-o-Matic. That should stop this from happening.
,
Sep 21 2017
This should be fixed now. Let me know if it happens again though! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by donnd@google.com
, Sep 14 2017