New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 765481 link

Starred by 2 users
Status: Fixed
Owner:
valleau@chromium.org
Closed: Oct 2017
Cc:
weifangsun@chromium.org
█ justincarlson@chromium.org
skau@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Incorrect Error Reported for Invalid PPD

Project Member Reported by skau@chromium.org, Sep 14 2017 
Chrome Version: 63
OS: CrOS

What steps will reproduce the problem?
(1) Setup an AppSocket Printer
(2) Choose an invalid PPD
(3) Try to add printer

What is the expected result?
kInvalidPPD since the PPD should be rejected by cupstestppd

https://cs.chromium.org/chromium/src/chrome/browser/chromeos/printing/printer_configurer.h?type=cs&q=PrinterConfigur&sq=package:chromium&l=29

What happens instead?
kPpdNotFound

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a87bdc2222369e5eee11b0f541a5dfb2f359c64

commit 7a87bdc2222369e5eee11b0f541a5dfb2f359c64
Author: David Valleau <valleau@chromium.org>
Date: Tue Sep 26 00:55:02 2017

Added PPD_TOO_LARGE to ppd_provider.h CallBackResultCode.

Using this new enum code the correct error will be displayed to the user
when then try to manually add a PPD which is too large. Before the
reported error was that the PPD was unable to be retrieved by the
server.

R=skau@chromium.org

Bug:  766767 , 765481 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I281d92f89c7baff5ce5530924d06c76ea1480791
Reviewed-on: https://chromium-review.googlesource.com/673551
Commit-Queue: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504244}
[modify] https://crrev.com/7a87bdc2222369e5eee11b0f541a5dfb2f359c64/chrome/browser/chromeos/printing/printer_configurer.cc
[modify] https://crrev.com/7a87bdc2222369e5eee11b0f541a5dfb2f359c64/chromeos/printing/ppd_provider.cc
[modify] https://crrev.com/7a87bdc2222369e5eee11b0f541a5dfb2f359c64/chromeos/printing/ppd_provider.h

Comment 2 by skau@chromium.org, Oct 11 2017

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment